VideoTrackRecorder: Adding inner class H264Encoder

content/content.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,  # Use higher warning level.
     'chromium_enable_vtune_jit_for_v8%': 0,  # enable the vtune support for V8 engine.
   },
   'target_defaults': {
@@ skipping 265 matching lines @@
           'type': 'static_library',
           'variables': { 'enable_wexit_time_destructors': 1, },
           'includes': [
             'content_ppapi_plugin.gypi',
           ],
           # Disable c4267 warnings until we fix size_t to int truncations.
           'msvs_disabled_warnings': [ 4267, ],
         },
         {
           # GN version: //content/renderer and //content/public/renderer
           'target_name': 'content_renderer',

[hbos_chromium, 2016/04/21 07:36:09]

Nice, but you forgot GN. Make the same changes for the GN version.

GN sample usage of rtc_use_h264:
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/com...
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/com...

[mcasas, 2016/04/21 15:09:18]

Done. Note that video_track_encoder.* is bundled
in the .gypi private_renderer_webrtc_sources and
is also sandwiched in an if(enabled_webrtc).

           'type': 'static_library',
           'variables': { 'enable_wexit_time_destructors': 1, },
           'includes': [
             'content_renderer.gypi',
+            '../third_party/webrtc/build/common.gypi',
           ],
           'dependencies': [
-            '../third_party/webrtc/modules/modules.gyp:webrtc_h264',
             'common_features',
             'content_child',
             'content_common',
             'content_gpu',
             'content_resources',
           ],
           'export_dependent_settings': [
             'content_common',
           ],
           'conditions': [
             ['chromium_enable_vtune_jit_for_v8==1', {
               'dependencies': [
                 '../v8/src/third_party/vtune/v8vtune.gyp:v8_vtune',
               ],
             }],
+            ['rtc_use_h264==1', {
+              'dependencies': [
+                  '../third_party/openh264/openh264.gyp:openh264_encoder',
+                  '../third_party/webrtc/modules/modules.gyp:webrtc_h264',
+              ],
+            }],
           ],
         },
         {
           # GN version: //content/utility and //content/public/utility
           'target_name': 'content_utility',
           'type': 'static_library',
           'variables': { 'enable_wexit_time_destructors': 1, },
           'includes': [
             'content_utility.gypi',
           ],
           'dependencies': [
             'content_child',
             'content_common',
             'content_common_mojo_bindings.gyp:content_common_mojo_bindings',
           ],
         },
       ],
     },
     {  # component != static_library
       'targets': [
         {
           # GN version: //content
           'target_name': 'content',

[hbos_chromium, 2016/04/21 07:36:09]

You should make a similar change here, when component != static_library the
content_* targets are merged into a big content target, and in that case
building content_renderer or any of the smaller targets means building all of
content. So the target is basically defined twice, as a small blob and as a
large blob, and changes have to be made in two places.

[mcasas, 2016/04/21 15:09:18]

Done.

           'type': 'shared_library',
           'variables': { 'enable_wexit_time_destructors': 1, },
           'dependencies': [
             '../third_party/webrtc/modules/modules.gyp:webrtc_h264',
             'common_features',
             'content_resources',
           ],
           'conditions': [
             ['chromium_enable_vtune_jit_for_v8==1', {
               'dependencies': [
@@ skipping 335 matching lines @@
           },
           'includes': [
             '../build/android/copy_ex.gypi',
             '../build/android/v8_external_startup_data_arch_suffix.gypi',
           ],
         },
       ],
     }],  # OS == "android"
   ],
 }