Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1884363002: Explicity use CFX_ByteStrings in a couple of places (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Explicity use CFX_ByteStrings in a couple of places These are exposed by making the ByteString from ByteStringC ctor explicit, but we can clean them up independently. Committed: https://pdfium.googlesource.com/pdfium/+/85fc26f3411584586707798c1ebf39a194f60cf0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Tom Sepez
4 years, 8 months ago (2016-04-15 01:10:50 UTC) #3
Tom Sepez
For review.
4 years, 8 months ago (2016-04-15 01:10:58 UTC) #4
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-15 01:15:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884363002/1
4 years, 8 months ago (2016-04-15 01:16:37 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 01:50:51 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/85fc26f3411584586707798c1ebf39a194f6...

Powered by Google App Engine
This is Rietveld 408576698