Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1884343002: Remove NSS from DEPS (Closed)

Created:
4 years, 8 months ago by Ryan Sleevi
Modified:
4 years, 8 months ago
Reviewers:
davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NSS from DEPS third_party/nss is no longer used on Mac/Windows/iOS, as it's all BoringSSL now. Clean up the DEPS entries. BUG=none Committed: https://crrev.com/2f3cbdb1d106ae2a5cb48bc10a6cec3dfef02fd1 Cr-Commit-Position: refs/heads/master@{#387536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M DEPS View 4 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Ryan Sleevi
David, you'll appreciate this :) (Also, still marked as OOO in Rietveld)
4 years, 8 months ago (2016-04-15 00:32:13 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884343002/1
4 years, 8 months ago (2016-04-15 00:32:49 UTC) #4
davidben
lgtm!!!!
4 years, 8 months ago (2016-04-15 01:00:34 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 02:44:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884343002/1
4 years, 8 months ago (2016-04-15 04:28:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 04:31:56 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 04:33:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f3cbdb1d106ae2a5cb48bc10a6cec3dfef02fd1
Cr-Commit-Position: refs/heads/master@{#387536}

Powered by Google App Engine
This is Rietveld 408576698