Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1884333002: Remove OILPAN from core/dom/shadow/ (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove OILPAN from core/dom/shadow/ R= BUG=585328 Committed: https://crrev.com/18900d944396257319834ead03e78b2f4c9a9000 Cr-Commit-Position: refs/heads/master@{#387541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -93 lines) Patch
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.h View 2 chunks +2 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp View 6 chunks +4 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp View 2 chunks +0 lines, -34 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-14 21:39:10 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-15 00:07:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884333002/1
4 years, 8 months ago (2016-04-15 05:24:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 05:28:08 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 05:30:27 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/18900d944396257319834ead03e78b2f4c9a9000
Cr-Commit-Position: refs/heads/master@{#387541}

Powered by Google App Engine
This is Rietveld 408576698