Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 188433003: Remove support for legacy WebKit Notifications (Closed)

Created:
6 years, 9 months ago by Peter Beverloo
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Remove support for legacy WebKit Notifications This patch removes support for the legacy WebKit notifications from Blink, per the following Intent to Remove thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8vqyfHa8_dw The interactive_ui_tests and browser_tests failures have since been addressed by CL 187803005. This is a re-land of: https://codereview.chromium.org/184733002/ TBR=atwilson@chromium.org, abarth@chromium.org BUG=348019 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168836

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -2103 lines) Patch
M LayoutTests/StaleTestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/notifications/notification-after-close.html View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/fast/notifications/notification-after-close-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/notifications/notification-exceptions.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/notifications/notification-exceptions-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-cancel-request-permission.html View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-cancel-request-permission-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-check-permission.html View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-check-permission-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-click-event.html View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-click-event-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-click-event-focus.html View 1 chunk +0 lines, -51 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-click-event-focus-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-display-close-events.html View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-display-close-events-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-document-close-crash.html View 1 chunk +0 lines, -50 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-document-close-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/notifications/notifications-event-stop-propagation.html-disabled View 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-event-stop-propagation-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-leak-document.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-leak-document-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-multi-events.html-disabled View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-multi-events-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-no-icon.html View 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-no-icon-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-replace.html View 1 chunk +0 lines, -41 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-replace-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-rtl.html View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-rtl-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-sandbox-permission.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-sandbox-permission-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-window-close-crash.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-window-close-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/notifications/notifications-with-permission.html View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-with-permission-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-without-permission.html View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/fast/notifications/notifications-without-permission-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/notifications/resources/notification-show.html View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/notifications/resources/notifications-cancel-request-permission.html View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/notifications/resources/notifications-iframe.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/android/fast/notifications/notifications-cancel-request-permission-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/events/EventTargetFactory.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/modules.gypi View 1 3 chunks +1 line, -14 lines 0 comments Download
D Source/modules/notifications/DOMWindowNotifications.h View 1 chunk +0 lines, -66 lines 0 comments Download
D Source/modules/notifications/DOMWindowNotifications.cpp View 1 chunk +0 lines, -107 lines 0 comments Download
M Source/modules/notifications/Notification.h View 4 chunks +70 lines, -9 lines 0 comments Download
M Source/modules/notifications/Notification.cpp View 7 chunks +104 lines, -8 lines 0 comments Download
D Source/modules/notifications/NotificationBase.h View 1 chunk +0 lines, -122 lines 0 comments Download
D Source/modules/notifications/NotificationBase.cpp View 1 chunk +0 lines, -154 lines 0 comments Download
D Source/modules/notifications/NotificationCenter.h View 1 chunk +0 lines, -113 lines 0 comments Download
D Source/modules/notifications/NotificationCenter.cpp View 1 chunk +0 lines, -144 lines 0 comments Download
D Source/modules/notifications/NotificationCenter.idl View 1 chunk +0 lines, -43 lines 0 comments Download
M Source/modules/notifications/NotificationClient.h View 2 chunks +4 lines, -7 lines 0 comments Download
D Source/modules/notifications/WebKitNotification.h View 1 chunk +0 lines, -78 lines 0 comments Download
D Source/modules/notifications/WebKitNotification.cpp View 1 chunk +0 lines, -83 lines 0 comments Download
D Source/modules/notifications/WebKitNotification.idl View 1 chunk +0 lines, -48 lines 0 comments Download
D Source/modules/notifications/WindowNotifications.idl View 1 chunk +0 lines, -33 lines 0 comments Download
D Source/modules/notifications/WorkerGlobalScopeNotifications.h View 1 1 chunk +0 lines, -65 lines 0 comments Download
D Source/modules/notifications/WorkerGlobalScopeNotifications.cpp View 1 1 chunk +0 lines, -83 lines 0 comments Download
D Source/modules/notifications/WorkerGlobalScopeNotifications.idl View 1 chunk +0 lines, -32 lines 0 comments Download
M Source/web/NotificationPresenterImpl.h View 1 chunk +3 lines, -6 lines 0 comments Download
M Source/web/NotificationPresenterImpl.cpp View 4 chunks +8 lines, -37 lines 0 comments Download
M Source/web/WebNotification.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M public/web/WebNotification.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Peter Beverloo
This is a re-land of a CL you previously committed, now with the tests fixed. ...
6 years, 9 months ago (2014-03-10 12:29:48 UTC) #1
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 9 months ago (2014-03-10 12:29:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/188433003/20001
6 years, 9 months ago (2014-03-10 12:30:43 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-10 13:14:10 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel
6 years, 9 months ago (2014-03-10 13:14:11 UTC) #5
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 9 months ago (2014-03-10 13:31:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/188433003/20001
6 years, 9 months ago (2014-03-10 13:31:57 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-10 14:17:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel
6 years, 9 months ago (2014-03-10 14:17:03 UTC) #9
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 9 months ago (2014-03-10 14:29:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/188433003/20001
6 years, 9 months ago (2014-03-10 14:30:30 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 15:30:14 UTC) #12
Message was sent while issue was closed. 
Change committed as 168836

Powered by Google App Engine
This is Rietveld 408576698