Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1884303005: Ported cdb copying from GYP to GN. (Closed)

Created:
4 years, 8 months ago by David Yen
Modified:
4 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews, telemetry-reviews_chromium.org, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ported cdb copying from GYP to GN. R=scottmg@chromium.org BUG=561763 Committed: https://crrev.com/22fdd41106d484763d987238b5fda54b4326decf Cr-Commit-Position: refs/heads/master@{#387755}

Patch Set 1 #

Patch Set 2 : Removed todo comments. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M build/win/copy_cdb_to_output.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M tools/perf/chrome_telemetry_build/BUILD.gn View 1 2 2 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
David Yen
4 years, 8 months ago (2016-04-15 21:21:15 UTC) #1
scottmg
lgtm
4 years, 8 months ago (2016-04-15 21:29:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884303005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884303005/40001
4 years, 8 months ago (2016-04-15 22:20:38 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-15 23:57:43 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 23:59:28 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/22fdd41106d484763d987238b5fda54b4326decf
Cr-Commit-Position: refs/heads/master@{#387755}

Powered by Google App Engine
This is Rietveld 408576698