Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1884293003: X87: [ic] Use the CallFunction builtin to invoke accessors. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [ic] Use the CallFunction builtin to invoke accessors. port 6df9a22c3f8d6640e867ca659c95e22289b00b40 (r35187) original commit message: The HandlerCompiler did not properly handle the weird edge case when a sloppy mode function was installed as an accessor on one of the value wrapper prototypes and then accessed via a load from a primitive value. In this case we just passed the primitive value untouched instead of properly wrapping it first. The CallFunction builtin properly deals with all the funny edge cases, so we use it instead of duplicating almost all of the logic here (the performance difference is neglible). BUG= Committed: https://crrev.com/96ddf420c56016c5ef463c61d09b721292ed786e Cr-Commit-Position: refs/heads/master@{#35522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/ic/x87/handler-compiler-x87.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-15 04:07:01 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-15 06:08:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884293003/1
4 years, 8 months ago (2016-04-15 06:37:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884293003/1
4 years, 8 months ago (2016-04-15 08:10:47 UTC) #8
Michael Achenbach
FYI: builders are hanging on this CL. Investigating...
4 years, 8 months ago (2016-04-15 11:26:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/16426) v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 8 months ago (2016-04-15 11:59:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884293003/1
4 years, 8 months ago (2016-04-15 11:59:39 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 12:21:17 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 12:21:41 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96ddf420c56016c5ef463c61d09b721292ed786e
Cr-Commit-Position: refs/heads/master@{#35522}

Powered by Google App Engine
This is Rietveld 408576698