Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1900)

Issue 1884253004: Revert of Update DisplacementMapEffect to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Update DisplacementMapEffect to sk_sp (patchset #3 id:40001 of https://codereview.chromium.org/1877783003/ ) Reason for revert: unexpected image diffs in imagefilterscropexpand GM Original issue's description: > Update DisplacementMapEffect to sk_sp > > TBR=reed@google.com > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1877783003 > > Committed: https://skia.googlesource.com/skia/+/a53011ef44705a091a8e24f7ea289a3f9ad759f2 TBR=fmalita@chromium.org,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/47db5fe4436c924f42b05bc63f8fad833b99bfbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -217 lines) Patch
M bench/DisplacementBench.cpp View 7 chunks +19 lines, -17 lines 0 comments Download
M bench/ImageFilterDAGBench.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M fuzz/FilterFuzz.cpp View 1 chunk +11 lines, -7 lines 0 comments Download
M gm/displacement.cpp View 1 chunk +121 lines, -121 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M gm/imagefilterscropexpand.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M gm/imagefilterstransformed.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M include/effects/SkDisplacementMapEffect.h View 2 chunks +7 lines, -21 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 chunk +11 lines, -7 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +12 lines, -15 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Update DisplacementMapEffect to sk_sp
4 years, 8 months ago (2016-04-15 12:09:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884253004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884253004/1
4 years, 8 months ago (2016-04-15 12:09:26 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 12:09:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/47db5fe4436c924f42b05bc63f8fad833b99bfbe

Powered by Google App Engine
This is Rietveld 408576698