Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1884213004: Fix a crash in debugger, add flag --stress-test-background-compilation, add asserts. (Closed)

Created:
4 years, 8 months ago by srdjan
Modified:
4 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a crash in debugger, add flag --stress-test-background-compilation, add asserts. Fix a crash in debugger: in background compilation check if the function is still marked as optimizable; setting breakpoints at runtime can change that. Add flag --stress-test-background-compilation which re-feeds compiled functions into the compilation queue. Add various asserts related to background compilation. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/ad6d0bc8a81010786546e167590a9c8872ed1eb1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -83 lines) Patch
M runtime/vm/code_generator.cc View 4 chunks +3 lines, -70 lines 0 comments Download
M runtime/vm/compiler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/compiler.cc View 7 chunks +85 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 15 chunks +31 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
srdjan
4 years, 8 months ago (2016-04-15 17:43:44 UTC) #2
rmacnak
lgtm
4 years, 8 months ago (2016-04-15 19:10:17 UTC) #3
srdjan
4 years, 8 months ago (2016-04-15 19:12:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ad6d0bc8a81010786546e167590a9c8872ed1eb1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698