DevTools: teach SourceMapNamesResolver to resolve "this" object

third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 24 matching lines @@
 }
 
 WebInspector.ScopeChainSidebarPane._pathSymbol = Symbol("path");
 
 WebInspector.ScopeChainSidebarPane.prototype = {
     /**
      * @param {?WebInspector.DebuggerModel.CallFrame} callFrame
      */
     update: function(callFrame)
     {
+        WebInspector.SourceMapNamesResolver.resolveThisObject(callFrame)

[dgozman, 2016/04/15 17:37:31]

I think this extra async will break some tests which sniff update or something.

[lushnikov, 2016/04/15 20:59:02]

Indeed, fixed them.

+            .then(this._innerUpdate.bind(this, callFrame));
+    },
+
+    /**
+     * @param {?WebInspector.DebuggerModel.CallFrame} callFrame
+     * @param {?WebInspector.RemoteObject} thisObject
+     */
+    _innerUpdate: function(callFrame, thisObject)
+    {
         this.element.removeChildren();
 
         if (!callFrame) {
             var infoElement = createElement("div");
             infoElement.className = "info";
             infoElement.textContent = WebInspector.UIString("Not Paused");
             this.element.appendChild(infoElement);
             return;
         }
 
         var foundLocalScope = false;
         var scopeChain = callFrame.scopeChain();
         for (var i = 0; i < scopeChain.length; ++i) {
             var scope = scopeChain[i];
             var title = null;
             var emptyPlaceholder = null;
             var extraProperties = [];
 
             switch (scope.type()) {
             case DebuggerAgent.ScopeType.Local:
                 foundLocalScope = true;
                 title = WebInspector.UIString("Local");
                 emptyPlaceholder = WebInspector.UIString("No Variables");
-                var thisObject = callFrame.thisObject();
                 if (thisObject)
                     extraProperties.push(new WebInspector.RemoteObjectProperty("this", thisObject));
                 if (i == 0) {
                     var details = callFrame.debuggerModel.debuggerPausedDetails();
                     var exception = details.exception();
                     if (exception)
                         extraProperties.push(new WebInspector.RemoteObjectProperty(WebInspector.UIString.capitalize("Exception"), exception, undefined, undefined, undefined, undefined, undefined, true));
                     var returnValue = callFrame.returnValue();
                     if (returnValue)
                         extraProperties.push(new WebInspector.RemoteObjectProperty(WebInspector.UIString.capitalize("Return ^value"), returnValue, undefined, undefined, undefined, undefined, undefined, true));
@@ skipping 36 matching lines @@
             this._expandController.watchSection(title + (subtitle ? ":" + subtitle : ""), section);
 
             if (scope.type() === DebuggerAgent.ScopeType.Global)
                 section.objectTreeElement().collapse();
             else if (!foundLocalScope || scope.type() === DebuggerAgent.ScopeType.Local)
                 section.objectTreeElement().expand();
 
             section.element.classList.add("scope-chain-sidebar-pane-section");
             this.element.appendChild(section.element);
         }
+        this._sidebarPaneUpdatedForTest();
     },
 
+    _sidebarPaneUpdatedForTest: function() { },
+
     __proto__: WebInspector.SidebarPane.prototype
 }