src/objects-inl.h - Issue 1884183002: First version of the new generators implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 1884183002: First version of the new generators implementation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index ab3b00a01edcde3512465bfc3485bb10132a2ba4..05f72db5ccacc7b5886379a6d83d3c87bc414e5b 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -6280,9 +6280,9 @@ SMI_ACCESSORS(JSGeneratorObject, continuation, kContinuationOffset)

ACCESSORS(JSGeneratorObject, operand_stack, FixedArray, kOperandStackOffset)

bool JSGeneratorObject::is_suspended() {

- DCHECK_LT(kGeneratorExecuting, kGeneratorClosed);

- DCHECK_EQ(kGeneratorClosed, 0);

- return continuation() > 0;

+ DCHECK_LT(kGeneratorExecuting, 0);

+ DCHECK_LT(kGeneratorClosed, 0);

+ return continuation() >= 0;

}

bool JSGeneratorObject::is_closed() {