Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1884173003: Allow to skip EnsureAuthenticated for Gerrit. (Closed)

Created:
4 years, 8 months ago by tandrii(chromium)
Modified:
4 years, 8 months ago
Reviewers:
Bons, Michael Achenbach
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow to skip EnsureAuthenticated for Gerrit. Adding this line to codereview.settings should do the trick: GERRIT_SKIP_ENSURE_AUTHENTICATED: true And I also cleaned up tests so they don't spill too much to stdout. BUG=603378 R=machenbach@chromium.org,andybons@chromium.org CC=shinyak@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -6 lines) Patch
M git_cl.py View 4 chunks +18 lines, -0 lines 0 comments Download
M tests/git_cl_test.py View 11 chunks +25 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
tandrii(chromium)
4 years, 8 months ago (2016-04-14 13:36:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884173003/1
4 years, 8 months ago (2016-04-14 13:37:00 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 13:39:31 UTC) #5
Michael Achenbach
lgtm
4 years, 8 months ago (2016-04-14 13:44:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884173003/1
4 years, 8 months ago (2016-04-14 13:44:20 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 13:46:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299926

Powered by Google App Engine
This is Rietveld 408576698