Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 1884133005: bluetooth: Separate readValue tests (Closed)

Created:
4 years, 8 months ago by ortuno
Modified:
4 years, 8 months ago
Reviewers:
Jeffrey Yasskin
CC:
blink-reviews, chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bluetooth-mojo-read-value
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Separate readValue tests BUG=554240 Committed: https://crrev.com/bd745c89802067c732b9858960cb4834e4b6b10d Cr-Commit-Position: refs/heads/master@{#388314}

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : Merge #

Total comments: 2

Patch Set 4 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -245 lines) Patch
D third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/readValue.html View 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/readValue-blacklist.html View 1 chunk +0 lines, -30 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/readValue/add-multiple-event-listeners.html View 1 chunk +32 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/readValue/blacklisted-characteristic.html View 2 chunks +5 lines, -9 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/readValue/characteristic-is-removed.html View 1 1 chunk +3 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/readValue/device-goes-out-of-range.html View 1 1 chunk +3 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/readValue/event-is-fired.html View 1 chunk +14 lines, -10 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/readValue/read-fails.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/readValue/read-succeeds.html View 1 2 3 1 chunk +7 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/readValue/read-updates-value.html View 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/readValue/service-is-removed.html View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884133005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884133005/20001
4 years, 8 months ago (2016-04-15 22:32:37 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/20120) ios_rel_device_ninja on ...
4 years, 8 months ago (2016-04-15 22:36:31 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884133005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884133005/40001
4 years, 8 months ago (2016-04-15 23:07:07 UTC) #6
ortuno
jyasskin: PTAL. I know I'm inundating you with CLs, let me know if there is ...
4 years, 8 months ago (2016-04-15 23:24:24 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-16 02:19:45 UTC) #10
Jeffrey Yasskin
lgtm https://codereview.chromium.org/1884133005/diff/40001/third_party/WebKit/LayoutTests/bluetooth/readValue/read-succeeds.html File third_party/WebKit/LayoutTests/bluetooth/readValue/read-succeeds.html (right): https://codereview.chromium.org/1884133005/diff/40001/third_party/WebKit/LayoutTests/bluetooth/readValue/read-succeeds.html#newcode21 third_party/WebKit/LayoutTests/bluetooth/readValue/read-succeeds.html:21: }, 'A read request succeeds and returns the ...
4 years, 8 months ago (2016-04-19 17:48:45 UTC) #11
ortuno
Thanks! https://codereview.chromium.org/1884133005/diff/40001/third_party/WebKit/LayoutTests/bluetooth/readValue/read-succeeds.html File third_party/WebKit/LayoutTests/bluetooth/readValue/read-succeeds.html (right): https://codereview.chromium.org/1884133005/diff/40001/third_party/WebKit/LayoutTests/bluetooth/readValue/read-succeeds.html#newcode21 third_party/WebKit/LayoutTests/bluetooth/readValue/read-succeeds.html:21: }, 'A read request succeeds and returns the ...
4 years, 8 months ago (2016-04-19 20:04:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884133005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884133005/60001
4 years, 8 months ago (2016-04-19 20:04:50 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-19 21:25:38 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:16:34 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bd745c89802067c732b9858960cb4834e4b6b10d
Cr-Commit-Position: refs/heads/master@{#388314}

Powered by Google App Engine
This is Rietveld 408576698