Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1884133004: Attempt to fix a hang in the GPU process while creating a D3D9 device. (Closed)

Created:
4 years, 8 months ago by ananta
Modified:
4 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt to fix a hang in the GPU process while creating a D3D9 device. Mimicing some of the checks in the firefox sources to avoid creating a device if we find that the driver does not support H/W format conversion and to use D3DCREATE_MIXED_VERTEXPROCESSING instead of D3DCREATE_HARDWARE_VERTEXPROCESSING. As per docs it means that the driver falls back to software vertex processing which is still better than doing the whole decoding on the CPU. Additionally I removed the D3DCREATE_DISABLE_PSGP_THREADING flag which restricts computation to the main thread in case the driver fallsback to software vertex processing which could affect performance. The expectation with this patch is we may be able to avoid device creation for a bunch of buggy drivers. BUG=602389 Committed: https://crrev.com/30968a7ee88a9efbd92de708f7d7564ab3d29451 Cr-Commit-Position: refs/heads/master@{#387738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator_win.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
ananta
4 years, 8 months ago (2016-04-15 02:13:50 UTC) #3
sandersd (OOO until July 31)
lgtm
4 years, 8 months ago (2016-04-15 23:03:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884133004/1
4 years, 8 months ago (2016-04-15 23:04:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 23:10:49 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 23:12:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30968a7ee88a9efbd92de708f7d7564ab3d29451
Cr-Commit-Position: refs/heads/master@{#387738}

Powered by Google App Engine
This is Rietveld 408576698