[Interpreter] Add support for FunctionEntryHook.

[Interpreter] Add support for FunctionEntryHook.

Adds code to call FunctionEntryHook on entry to the InterpreterEntryTrampoline.
This should give SyzyProf enough information to build non-discontinous profile
graphs, however since interpreter functions aren't uniquely identified they will
all get lumped into one bucket. This should be good enough for SyzyProf's current
use-case.

BUG=v8:4763
LOG=N

Committed: https://crrev.com/559113b092571821cec9cae774fd93ccbba61aae
Cr-Commit-Position: refs/heads/master@{#35568}

[rmcilroy, 2016-04-14 11:33:54]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 11:33:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884133002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884133002/1

[rmcilroy, 2016-04-14 11:34:10]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[rmcilroy, 2016-04-14 11:34:10]

Michi, PTAL, thanks.

[commit-bot: I haz the power, 2016-04-14 11:52:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 11:52:49]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/5821)
  v8_win64_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[rmcilroy, 2016-04-14 12:15:22]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 12:15:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884133002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884133002/20001

[commit-bot: I haz the power, 2016-04-14 12:30:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 12:30:01]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/137)
  v8_linux_arm_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)

[rmcilroy, 2016-04-14 12:44:21]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 12:44:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884133002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884133002/40001

[commit-bot: I haz the power, 2016-04-14 13:13:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 13:13:26]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-04-15 13:32:04]

Ping?

[Michael Starzinger, 2016-04-15 13:42:57]

LGTM with one suggestion.

https://codereview.chromium.org/1884133002/diff/40001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/1884133002/diff/40001/test/cctest/test-api.cc...
test/cctest/test-api.cc:14471: CHECK_NE(0, CountInvocations(NULL,
"InterpreterEntryTrampoline"));
Can this be made stricter by saying checking that we called the trampoline at
least 100 times? I was thinking about ...

CHECK_LE(100, CountInvocations(NULL, "InterpreterEntryTrampoline"));

[rmcilroy, 2016-04-18 09:25:43]

https://codereview.chromium.org/1884133002/diff/40001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/1884133002/diff/40001/test/cctest/test-api.cc...
test/cctest/test-api.cc:14471: CHECK_NE(0, CountInvocations(NULL,
"InterpreterEntryTrampoline"));
On 2016/04/15 13:42:56, Michael Starzinger wrote:
> Can this be made stricter by saying checking that we called the trampoline at
> least 100 times? I was thinking about ...
> 
> CHECK_LE(100, CountInvocations(NULL, "InterpreterEntryTrampoline"));

Went with the minimum of 102 (100 calls of foo and 2 of bar) to be even stricter
:).

[rmcilroy, 2016-04-18 09:26:04]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-04-18 09:26:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1884133002/#ps60001
(title: "Make test stricter")

[commit-bot: I haz the power, 2016-04-18 09:26:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884133002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884133002/60001

[commit-bot: I haz the power, 2016-04-18 09:49:31]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-18 09:51:27]

Description was changed from

==========
[Interpreter] Add support for FunctionEntryHook.

Adds code to call FunctionEntryHook on entry to the InterpreterEntryTrampoline.
This should give SyzyProf enough information to build non-discontinous profile
graphs, however since interpreter functions aren't uniquely identified they will
all get lumped into one bucket. This should be good enough for SyzyProf's
current
use-case.

BUG=v8:4763
LOG=N
==========

to

==========
[Interpreter] Add support for FunctionEntryHook.

Adds code to call FunctionEntryHook on entry to the InterpreterEntryTrampoline.
This should give SyzyProf enough information to build non-discontinous profile
graphs, however since interpreter functions aren't uniquely identified they will
all get lumped into one bucket. This should be good enough for SyzyProf's
current
use-case.

BUG=v8:4763
LOG=N

Committed: https://crrev.com/559113b092571821cec9cae774fd93ccbba61aae
Cr-Commit-Position: refs/heads/master@{#35568}
==========

[commit-bot: I haz the power, 2016-04-18 09:51:29]

Patchset 4 (id:??) landed as
https://crrev.com/559113b092571821cec9cae774fd93ccbba61aae
Cr-Commit-Position: refs/heads/master@{#35568}