Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: third_party/WebKit/Source/platform/heap/Handle.h

Issue 1884113002: Remove RawPtr.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix HeapTest.Bind expectation Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/Handle.h
diff --git a/third_party/WebKit/Source/platform/heap/Handle.h b/third_party/WebKit/Source/platform/heap/Handle.h
index 41fb5f833578efee015a44b7a78c54e5be4332ef..2313a77dea445fc3564de6116cd2ced698542b5d 100644
--- a/third_party/WebKit/Source/platform/heap/Handle.h
+++ b/third_party/WebKit/Source/platform/heap/Handle.h
@@ -43,7 +43,6 @@
#include "wtf/Functional.h"
#include "wtf/HashFunctions.h"
#include "wtf/Locker.h"
-#include "wtf/RawPtr.h"
#include "wtf/RefCounted.h"
#include "wtf/TypeTraits.h"
@@ -118,13 +117,6 @@ public:
checkPointer();
}
- template<typename U>
- PersistentBase(const RawPtr<U>& other) : m_raw(other.get())
- {
- initialize();
- checkPointer();
- }
-
~PersistentBase()
{
uninitialize();
@@ -154,7 +146,6 @@ public:
T& operator*() const { return *m_raw; }
bool operator!() const { return !m_raw; }
operator T*() const { return m_raw; }
- operator RawPtr<T>() const { return m_raw; }
T* operator->() const { return *this; }
T* get() const { return m_raw; }
@@ -191,13 +182,6 @@ public:
return *this;
}
- template<typename U>
- PersistentBase& operator=(const RawPtr<U>& other)
- {
- assign(other);
- return *this;
- }
-
#if defined(LEAK_SANITIZER)
PersistentBase* registerAsStaticReference()
{
@@ -313,8 +297,6 @@ public:
Persistent(const Persistent<U>& other) : Parent(other) { }
template<typename U>
Persistent(const Member<U>& other) : Parent(other) { }
- template<typename U>
- Persistent(const RawPtr<U>& other) : Parent(other.get()) { }
template<typename U>
Persistent& operator=(U* other)
@@ -348,13 +330,6 @@ public:
Parent::operator=(other);
return *this;
}
-
- template<typename U>
- Persistent& operator=(const RawPtr<U>& other)
- {
- Parent::operator=(other);
- return *this;
- }
};
// WeakPersistent is a way to create a weak pointer from an off-heap object
@@ -381,8 +356,6 @@ public:
WeakPersistent(const WeakPersistent<U>& other) : Parent(other) { }
template<typename U>
WeakPersistent(const Member<U>& other) : Parent(other) { }
- template<typename U>
- WeakPersistent(const RawPtr<U>& other) : Parent(other.get()) { }
template<typename U>
WeakPersistent& operator=(U* other)
@@ -416,13 +389,6 @@ public:
Parent::operator=(other);
return *this;
}
-
- template<typename U>
- WeakPersistent& operator=(const RawPtr<U>& other)
- {
- Parent::operator=(other);
- return *this;
- }
};
// Unlike Persistent, we can destruct a CrossThreadPersistent in a thread
@@ -440,8 +406,6 @@ public:
CrossThreadPersistent(const CrossThreadPersistent<U>& other) : Parent(other) { }
template<typename U>
CrossThreadPersistent(const Member<U>& other) : Parent(other) { }
- template<typename U>
- CrossThreadPersistent(const RawPtr<U>& other) : Parent(other.get()) { }
T* atomicGet() { return Parent::atomicGet(); }
@@ -477,13 +441,6 @@ public:
Parent::operator=(other);
return *this;
}
-
- template<typename U>
- CrossThreadPersistent& operator=(const RawPtr<U>& other)
- {
- Parent::operator=(other);
- return *this;
- }
};
// Combines the behavior of CrossThreadPersistent and WeakPersistent.
@@ -500,8 +457,6 @@ public:
CrossThreadWeakPersistent(const CrossThreadWeakPersistent<U>& other) : Parent(other) { }
template<typename U>
CrossThreadWeakPersistent(const Member<U>& other) : Parent(other) { }
- template<typename U>
- CrossThreadWeakPersistent(const RawPtr<U>& other) : Parent(other.get()) { }
template<typename U>
CrossThreadWeakPersistent& operator=(U* other)
@@ -535,13 +490,6 @@ public:
Parent::operator=(other);
return *this;
}
-
- template<typename U>
- CrossThreadWeakPersistent& operator=(const RawPtr<U>& other)
- {
- Parent::operator=(other);
- return *this;
- }
};
template<typename Collection>
@@ -731,12 +679,6 @@ public:
checkPointer();
}
- template<typename U>
- Member(const RawPtr<U>& other) : m_raw(other.get())
- {
- checkPointer();
- }
-
Member(WTF::HashTableDeletedValueType) : m_raw(reinterpret_cast<T*>(-1))
{
}
@@ -773,8 +715,6 @@ public:
T* operator->() const { return m_raw; }
T& operator*() const { return *m_raw; }
- template<typename U>
- operator RawPtr<U>() const { return m_raw; }
template<typename U>
Member& operator=(const Persistent<U>& other)
@@ -800,14 +740,6 @@ public:
return *this;
}
- template<typename U>
- Member& operator=(RawPtr<U> other)
- {
- m_raw = other;
- checkPointer();
- return *this;
- }
-
Member& operator=(std::nullptr_t)
{
m_raw = nullptr;
@@ -907,14 +839,6 @@ public:
return *this;
}
- template<typename U>
- WeakMember& operator=(const RawPtr<U>& other)
- {
- this->m_raw = other;
- this->checkPointer();
- return *this;
- }
-
WeakMember& operator=(std::nullptr_t)
{
this->m_raw = nullptr;
@@ -945,9 +869,6 @@ public:
UntracedMember(T* raw) : Member<T>(raw) { }
template<typename U>
- UntracedMember(const RawPtr<U>& other) : Member<T>(other) { }
-
- template<typename U>
UntracedMember(const Persistent<U>& other) : Member<T>(other) { }
template<typename U>
@@ -979,14 +900,6 @@ public:
return *this;
}
- template<typename U>
- UntracedMember& operator=(const RawPtr<U>& other)
- {
- this->m_raw = other;
- this->checkPointer();
- return *this;
- }
-
UntracedMember& operator=(std::nullptr_t)
{
this->m_raw = nullptr;
@@ -1009,7 +922,7 @@ template<typename T, bool = IsGarbageCollectedType<T>::value>
class RawPtrOrMemberTrait {
STATIC_ONLY(RawPtrOrMemberTrait)
public:
- using Type = RawPtr<T>;
+ using Type = T*;
};
template<typename T>
@@ -1260,12 +1173,6 @@ struct ParamStorageTraits<T*> : public PointerParamStorageTraits<T*, blink::IsGa
};
template<typename T>
-struct ParamStorageTraits<RawPtr<T>> : public PointerParamStorageTraits<T*, blink::IsGarbageCollectedType<T>::value> {
- STATIC_ONLY(ParamStorageTraits);
- static_assert(sizeof(T), "T must be fully defined");
-};
-
-template<typename T>
struct ParamStorageTraits<blink::WeakPersistentThisPointer<T>> {
STATIC_ONLY(ParamStorageTraits);
static_assert(sizeof(T), "T must be fully defined");
« no previous file with comments | « third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md ('k') | third_party/WebKit/Source/platform/heap/Heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698