Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1884113002: Remove RawPtr.h (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
CC:
Mads Ager (chromium), blink-reviews, blink-reviews-api_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-wtf_chromium.org, chromium-reviews, dglazkov+blink, dshwang, eae+blinkwatch, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, kouhei+heap_chromium.org, loading-reviews_chromium.org, Mikhail, oilpan-reviews, rwlbuis, sof, slimming-paint-reviews_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove RawPtr.h No longer used, so retire this Oilpan transitional wrapper type. R= BUG=585328 Committed: https://crrev.com/5e52317c7314487707e4707169a2e20e7695fa4f Cr-Commit-Position: refs/heads/master@{#387300}

Patch Set 1 #

Patch Set 2 : rebased upto r387279 #

Patch Set 3 : fix HeapTest.Bind expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -355 lines) Patch
M third_party/WebKit/Source/core/dom/DocumentParserTiming.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentTiming.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintTiming.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/CrossThreadCopier.h View 4 chunks +3 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Handle.h View 1 20 chunks +1 line, -94 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTerminatedArray.h View 1 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 2 3 chunks +2 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/TraceTraits.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebSpeechRecognitionResult.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashFunctions.h View 2 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashTraits.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/PassRefPtr.h View 4 chunks +0 lines, -22 lines 0 comments Download
D third_party/WebKit/Source/wtf/RawPtr.h View 1 chunk +0 lines, -150 lines 0 comments Download
M third_party/WebKit/Source/wtf/RefPtr.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/TerminatedArray.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/TypeTraits.h View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/public/platform/WebPrivatePtr.h View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
sof
please take a look (tkent@ for public/ WebPrivatePtr.h change.)
4 years, 8 months ago (2016-04-14 11:14:15 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-14 11:19:56 UTC) #4
tkent
lgtm
4 years, 8 months ago (2016-04-14 13:37:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884113002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884113002/40001
4 years, 8 months ago (2016-04-14 13:39:31 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-14 13:45:43 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 13:46:59 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5e52317c7314487707e4707169a2e20e7695fa4f
Cr-Commit-Position: refs/heads/master@{#387300}

Powered by Google App Engine
This is Rietveld 408576698