Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 1884103002: [crankshaft] Hook the binary operators TurboFan code stubs with crankshaft. (Closed)

Created:
4 years, 8 months ago by epertoso
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Hook the binary operators TurboFan code stubs with crankshaft. Replaces the HCallRuntime instruction in HGraphBuilder::BuildBinaryOperation with a call to the corresponding TurboFan stub. Committed: https://crrev.com/1b63d124ad6d608d09e85d5773e87f3123a942bc Cr-Commit-Position: refs/heads/master@{#35479}

Patch Set 1 #

Patch Set 2 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M src/crankshaft/hydrogen.cc View 1 1 chunk +22 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
epertoso
4 years, 8 months ago (2016-04-14 09:07:09 UTC) #3
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-14 09:08:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884103002/20001
4 years, 8 months ago (2016-04-14 09:17:31 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 09:38:12 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 09:40:06 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1b63d124ad6d608d09e85d5773e87f3123a942bc
Cr-Commit-Position: refs/heads/master@{#35479}

Powered by Google App Engine
This is Rietveld 408576698