chrome/browser/ui/website_settings/permission_bubble_manager.cc - Issue 1884073002: Add a new metric for how many times permissions prompts are shown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager.cc

Issue 1884073002: Add a new metric for how many times permissions prompts are shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_uma_util.cc ('k') | chrome/browser/ui/website_settings/permission_bubble_request.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/permission_bubble_manager.cc

diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager.cc b/chrome/browser/ui/website_settings/permission_bubble_manager.cc

index 194ae9c2c390bccdd48b8657bf2d4cbda7281064..cb3739c3eddf47b6d60633e1371e4a58debda81d 100644

--- a/chrome/browser/ui/website_settings/permission_bubble_manager.cc

+++ b/chrome/browser/ui/website_settings/permission_bubble_manager.cc

@@ -9,6 +9,7 @@

#include "base/command_line.h"

#include "base/metrics/user_metrics_action.h"

#include "build/build_config.h"

+#include "chrome/browser/permissions/permission_uma_util.h"

#include "chrome/browser/ui/website_settings/permission_bubble_request.h"

#include "chrome/common/chrome_switches.h"

#include "content/public/browser/browser_thread.h"

@@ -385,6 +386,7 @@ void PermissionBubbleManager::TriggerShowBubble() {

}

view_->Show(requests_, accept_states_);

+ PermissionUmaUtil::PermissionPromptShown(requests_);

NotifyBubbleAdded();

// If in testing mode, automatically respond to the bubble that was shown.