Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 1884073002: Add a new metric for how many times permissions prompts are shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_uma_util.h" 5 #include "chrome/browser/permissions/permission_uma_util.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/metrics/histogram_macros.h" 9 #include "base/metrics/histogram_macros.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
11 #include "chrome/browser/browser_process.h" 11 #include "chrome/browser/browser_process.h"
12 #include "chrome/browser/permissions/permission_manager.h" 12 #include "chrome/browser/permissions/permission_manager.h"
13 #include "chrome/browser/permissions/permission_util.h" 13 #include "chrome/browser/permissions/permission_util.h"
14 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
15 #include "chrome/browser/ui/website_settings/permission_bubble_request.h"
15 #include "components/rappor/rappor_service.h" 16 #include "components/rappor/rappor_service.h"
16 #include "components/rappor/rappor_utils.h" 17 #include "components/rappor/rappor_utils.h"
17 #include "content/public/browser/permission_type.h" 18 #include "content/public/browser/permission_type.h"
18 #include "content/public/common/origin_util.h" 19 #include "content/public/common/origin_util.h"
19 #include "url/gurl.h" 20 #include "url/gurl.h"
20 21
21 // UMA keys need to be statically initialized so plain function would not 22 // UMA keys need to be statically initialized so plain function would not
22 // work. Use a Macro instead. 23 // work. Use a Macro instead.
23 #define PERMISSION_ACTION_UMA(secure_origin, permission, permission_secure, \ 24 #define PERMISSION_ACTION_UMA(secure_origin, permission, permission_secure, \
24 permission_insecure, action) \ 25 permission_insecure, action) \
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 const GURL& revoked_origin) { 268 const GURL& revoked_origin) {
268 // TODO(tsergeant): Expand metrics definitions for revocation to include all 269 // TODO(tsergeant): Expand metrics definitions for revocation to include all
269 // permissions. 270 // permissions.
270 if (permission == PermissionType::NOTIFICATIONS || 271 if (permission == PermissionType::NOTIFICATIONS ||
271 permission == PermissionType::GEOLOCATION || 272 permission == PermissionType::GEOLOCATION ||
272 permission == PermissionType::AUDIO_CAPTURE || 273 permission == PermissionType::AUDIO_CAPTURE ||
273 permission == PermissionType::VIDEO_CAPTURE) { 274 permission == PermissionType::VIDEO_CAPTURE) {
274 RecordPermissionAction(permission, REVOKED, revoked_origin); 275 RecordPermissionAction(permission, REVOKED, revoked_origin);
275 } 276 }
276 } 277 }
278
279 void PermissionUmaUtil::PermissionPromptShown(
280 const std::vector<PermissionBubbleRequest*>& requests) {
281 DCHECK(!requests.empty());
282 PermissionBubbleType permission_prompt_type = PermissionBubbleType::MULTIPLE;
283 if (requests.size() == 1)
284 permission_prompt_type = requests[0]->GetPermissionBubbleType();
285 UMA_HISTOGRAM_ENUMERATION(
286 "Permissions.Prompt.Shown",
287 static_cast<base::HistogramBase::Sample>(permission_prompt_type),
288 static_cast<base::HistogramBase::Sample>(PermissionBubbleType::NUM));
289 }
OLDNEW
« no previous file with comments | « chrome/browser/permissions/permission_uma_util.h ('k') | chrome/browser/ui/website_settings/permission_bubble_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698