Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 1884043002: Use black for resize gutter in tab fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_aura.h" 5 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
6 6
7 #include <set> 7 #include <set>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 2831 matching lines...) Expand 10 before | Expand all | Expand 10 after
2842 // DelegatedFrameHost, public: 2842 // DelegatedFrameHost, public:
2843 2843
2844 ui::Layer* RenderWidgetHostViewAura::DelegatedFrameHostGetLayer() const { 2844 ui::Layer* RenderWidgetHostViewAura::DelegatedFrameHostGetLayer() const {
2845 return window_->layer(); 2845 return window_->layer();
2846 } 2846 }
2847 2847
2848 bool RenderWidgetHostViewAura::DelegatedFrameHostIsVisible() const { 2848 bool RenderWidgetHostViewAura::DelegatedFrameHostIsVisible() const {
2849 return !host_->is_hidden(); 2849 return !host_->is_hidden();
2850 } 2850 }
2851 2851
2852 void RenderWidgetHostViewAura::DelegatedFrameHostOverrideGutterColor(
2853 SkColor* color) const {
2854 // In fullscreen mode resizing is uncommon, so it makes more sense to make
2855 // the initial switch to fullscreen mode look better by using black as the
danakj 2016/04/25 22:17:58 Doesn't this make a black flash if the page is whi
2856 // gutter color.
2857 if (host_->delegate()->IsFullscreenForCurrentTab(host_))
2858 *color = SK_ColorBLACK;
2859 }
2860
2852 gfx::Size RenderWidgetHostViewAura::DelegatedFrameHostDesiredSizeInDIP() const { 2861 gfx::Size RenderWidgetHostViewAura::DelegatedFrameHostDesiredSizeInDIP() const {
2853 return window_->bounds().size(); 2862 return window_->bounds().size();
2854 } 2863 }
2855 2864
2856 bool RenderWidgetHostViewAura::DelegatedFrameCanCreateResizeLock() const { 2865 bool RenderWidgetHostViewAura::DelegatedFrameCanCreateResizeLock() const {
2857 #if !defined(OS_CHROMEOS) 2866 #if !defined(OS_CHROMEOS)
2858 // On Windows and Linux, holding pointer moves will not help throttling 2867 // On Windows and Linux, holding pointer moves will not help throttling
2859 // resizes. 2868 // resizes.
2860 // TODO(piman): on Windows we need to block (nested message loop?) the 2869 // TODO(piman): on Windows we need to block (nested message loop?) the
2861 // WM_SIZE event. On Linux we need to throttle at the WM level using 2870 // WM_SIZE event. On Linux we need to throttle at the WM level using
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
2927 2936
2928 //////////////////////////////////////////////////////////////////////////////// 2937 ////////////////////////////////////////////////////////////////////////////////
2929 // RenderWidgetHostViewBase, public: 2938 // RenderWidgetHostViewBase, public:
2930 2939
2931 // static 2940 // static
2932 void RenderWidgetHostViewBase::GetDefaultScreenInfo(WebScreenInfo* results) { 2941 void RenderWidgetHostViewBase::GetDefaultScreenInfo(WebScreenInfo* results) {
2933 GetScreenInfoForWindow(results, NULL); 2942 GetScreenInfoForWindow(results, NULL);
2934 } 2943 }
2935 2944
2936 } // namespace content 2945 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698