Implement BluetoothTestBlueZ and enable some LE tests.

device/bluetooth/test/bluetooth_test_bluez.cc

Index: device/bluetooth/test/bluetooth_test_bluez.cc
diff --git a/device/bluetooth/test/bluetooth_test_bluez.cc b/device/bluetooth/test/bluetooth_test_bluez.cc
new file mode 100644
index 0000000000000000000000000000000000000000..69b3b6d5c73d98513327fd006d87d58efc4c5166
--- /dev/null
+++ b/device/bluetooth/test/bluetooth_test_bluez.cc
@@ -0,0 +1,110 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "device/bluetooth/test/bluetooth_test_bluez.h"
+
+#include <iterator>
+#include <sstream>
+
+#include "base/logging.h"
+#include "base/run_loop.h"
+#include "device/bluetooth/bluetooth_adapter_bluez.h"
+#include "device/bluetooth/bluetooth_device_bluez.h"
+#include "device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h"
+#include "device/bluetooth/bluetooth_remote_gatt_descriptor_bluez.h"
+#include "device/bluetooth/bluetooth_remote_gatt_service_bluez.h"
+#include "device/bluetooth/dbus/bluez_dbus_manager.h"
+#include "device/bluetooth/dbus/fake_bluetooth_adapter_client.h"
+#include "device/bluetooth/dbus/fake_bluetooth_device_client.h"
+#include "device/bluetooth/test/test_bluetooth_adapter_observer.h"
+
+namespace device {
+
+namespace {
+
+void AdapterCallback(base::Closure quit_closure) {
+  quit_closure.Run();
+}
+}
+
+BluetoothTestBlueZ::BluetoothTestBlueZ()
+    : fake_bluetooth_device_client_(nullptr) {}
+
+BluetoothTestBlueZ::~BluetoothTestBlueZ() {}
+
+void BluetoothTestBlueZ::SetUp() {
+  std::unique_ptr<bluez::BluezDBusManagerSetter> dbus_setter =
+      bluez::BluezDBusManager::GetSetterForTesting();
+  fake_bluetooth_device_client_ = new bluez::FakeBluetoothDeviceClient;
+  // TODO(rkc): This is a big hacky. Creating a device client creates three
+  // devices by default. For now, the easiest path is to just clear them, but
+  // a better way will be to only create them as needed. This will require
+  // looking at a lot of tests but should be done eventually.
+  fake_bluetooth_device_client_->RemoveAllDevices();
+  dbus_setter->SetBluetoothDeviceClient(
+      std::unique_ptr<bluez::BluetoothDeviceClient>(
+          fake_bluetooth_device_client_));
+}
+
+void BluetoothTestBlueZ::TearDown() {
+  adapter_ = nullptr;
+  bluez::BluezDBusManager::Shutdown();
+}
+
+bool BluetoothTestBlueZ::PlatformSupportsLowEnergy() {
+  return true;
+}
+
+void BluetoothTestBlueZ::InitWithDefaultAdapter() {

[scheib, 2016/04/15 19:44:45]

This doesn't bring up the hardware adapter, which is the intent of
InitWithDefaultAdapter. There isn't a need for the 1 test this enables - and
it's not a blocker for your subsequent needs. So let's just skip it.

[rkc, 2016/04/15 20:26:06]

Done.

+  base::RunLoop run_loop;
+  adapter_ = new bluez::BluetoothAdapterBlueZ(
+      base::Bind(&AdapterCallback, run_loop.QuitClosure()));
+  run_loop.Run();
+}
+
+void BluetoothTestBlueZ::InitWithFakeAdapter() {
+  base::RunLoop run_loop;
+  adapter_ = new bluez::BluetoothAdapterBlueZ(
+      base::Bind(&AdapterCallback, run_loop.QuitClosure()));
+  run_loop.Run();
+}
+
+BluetoothDevice* BluetoothTestBlueZ::DiscoverLowEnergyDevice(
+    int device_ordinal) {
+  if (device_ordinal > 4 || device_ordinal < 1)
+    return nullptr;
+
+  std::string device_name = kTestDeviceName;
+  std::string device_address = kTestDeviceAddress1;
+  std::vector<std::string> service_uuids;
+
+  switch (device_ordinal) {
+    case 1: {
+      service_uuids.push_back(kTestUUIDGenericAccess);
+      service_uuids.push_back(kTestUUIDGenericAttribute);
+    } break;

[scheib, 2016/04/15 19:44:45]

optional: 
"} break;" looks odd to me, though I see I didn't catch it in _win.cc. I see in
code search that it is used some (48 results excluding 3rd party, compared to
10,480 hits of 'switch'). I think avoid the uncommon form. If you change it here
please fix the _win.cc too.

[rkc, 2016/04/15 20:26:06]

I copy/pasted this without looking too hard. This is indeed odd. Fixed, here and
in _win.cc.
Done.

+    case 2: {
+      service_uuids.push_back(kTestUUIDImmediateAlert);
+      service_uuids.push_back(kTestUUIDLinkLoss);
+    } break;
+    case 3: {
+      device_name = kTestDeviceNameEmpty;
+    } break;
+    case 4: {
+      device_name = kTestDeviceNameEmpty;
+      device_address = kTestDeviceAddress2;
+    } break;
+  }
+
+  if (!adapter_->GetDevice(device_address)) {
+    fake_bluetooth_device_client_->CreateTestDevice(
+        dbus::ObjectPath(bluez::FakeBluetoothAdapterClient::kAdapterPath),
+        device_name /* name */, device_name /* alias */, device_address,
+        service_uuids);
+  }
+  BluetoothDevice* device = adapter_->GetDevice(device_address);
+
+  return device;
+}
+}