Implement BluetoothTestBlueZ and enable some LE tests.

Implement BluetoothTestBlueZ and enable some LE tests.

This CL adds an initial implementation of BluetoothTestBlueZ and enables
some basic x-platform Bluetooth tests. Going foward, any new code written
for Bluetooth, including specifically for BlueZ, should use these test
fixtures.

R=ortuno@chromium.org, scheib@chromium.org
BUG=603368
Committed: https://crrev.com/519a20c6b2f426c891a987289f4da1527531c032
Cr-Commit-Position: refs/heads/master@{#387819}

[rkc, 2016-04-14 03:47:10]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 03:47:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884033002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884033002/1

[commit-bot: I haz the power, 2016-04-14 04:05:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 04:05:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rkc, 2016-04-14 05:27:02]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 05:27:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884033002/20001

[commit-bot: I haz the power, 2016-04-14 06:25:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 06:25:20]

Dry run: This issue passed the CQ dry run.

[rkc, 2016-04-15 19:05:37]

ping?

This is a fairly small CL, but it sets the direction that I'd write further
tests in.

[scheib, 2016-04-15 19:44:45]

https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_unittest.cc (right):

https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_unittest.cc:424: InitWithDefaultAdapter();
Skip brining up this test, see below...

https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/test/b...
File device/bluetooth/test/bluetooth_test_bluez.cc (right):

https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_bluez.cc:59: void
BluetoothTestBlueZ::InitWithDefaultAdapter() {
This doesn't bring up the hardware adapter, which is the intent of
InitWithDefaultAdapter. There isn't a need for the 1 test this enables - and
it's not a blocker for your subsequent needs. So let's just skip it.

https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_bluez.cc:86: } break;
optional: 
"} break;" looks odd to me, though I see I didn't catch it in _win.cc. I see in
code search that it is used some (48 results excluding 3rd party, compared to
10,480 hits of 'switch'). I think avoid the uncommon form. If you change it here
please fix the _win.cc too.

https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/test/b...
File device/bluetooth/test/bluetooth_test_bluez.h (right):

https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_bluez.h:11: class
FakeBluetoothAdapterClient;
AdapterClient doesn't seem used yet.

https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_bluez.h:17: class
BluetoothAdapterProfileBlueZ;
I'm unsure what this is used for.

[rkc, 2016-04-15 20:26:06]

https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_unittest.cc (right):

https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_unittest.cc:424: InitWithDefaultAdapter();
On 2016/04/15 19:44:44, scheib wrote:
> Skip brining up this test, see below...

Done.

https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/test/b...
File device/bluetooth/test/bluetooth_test_bluez.cc (right):

https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_bluez.cc:59: void
BluetoothTestBlueZ::InitWithDefaultAdapter() {
On 2016/04/15 19:44:45, scheib wrote:
> This doesn't bring up the hardware adapter, which is the intent of
> InitWithDefaultAdapter. There isn't a need for the 1 test this enables - and
> it's not a blocker for your subsequent needs. So let's just skip it.

Done.

https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_bluez.cc:86: } break;
On 2016/04/15 19:44:45, scheib wrote:
> optional: 
> "} break;" looks odd to me, though I see I didn't catch it in _win.cc. I see
in
> code search that it is used some (48 results excluding 3rd party, compared to
> 10,480 hits of 'switch'). I think avoid the uncommon form. If you change it
here
> please fix the _win.cc too.

I copy/pasted this without looking too hard. This is indeed odd. Fixed, here and
in _win.cc.
Done.

https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/test/b...
File device/bluetooth/test/bluetooth_test_bluez.h (right):

https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_bluez.h:11: class
FakeBluetoothAdapterClient;
On 2016/04/15 19:44:45, scheib wrote:
> AdapterClient doesn't seem used yet.

Done.

https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_bluez.h:17: class
BluetoothAdapterProfileBlueZ;
On 2016/04/15 19:44:45, scheib wrote:
> I'm unsure what this is used for.

Isn't. I was experimenting and forgot to remove.
Done.

[scheib, 2016-04-15 21:20:41]

https://codereview.chromium.org/1884033002/diff/40001/device/bluetooth/test/b...
File device/bluetooth/test/bluetooth_test_bluez.h (right):

https://codereview.chromium.org/1884033002/diff/40001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_bluez.h:28: void InitWithDefaultAdapter()
override;
Remove 'InitWithDefaultAdapter' since it isn't implemented as intended.

[rkc, 2016-04-15 21:24:54]

https://codereview.chromium.org/1884033002/diff/40001/device/bluetooth/test/b...
File device/bluetooth/test/bluetooth_test_bluez.h (right):

https://codereview.chromium.org/1884033002/diff/40001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_bluez.h:28: void InitWithDefaultAdapter()
override;
On 2016/04/15 21:20:40, scheib wrote:
> Remove 'InitWithDefaultAdapter' since it isn't implemented as intended.

Done.

[scheib, 2016-04-15 21:40:43]

LGTM

[rkc, 2016-04-16 01:59:31]

The CQ bit was checked by rkc@chromium.org

[commit-bot: I haz the power, 2016-04-16 01:59:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884033002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884033002/60001

[commit-bot: I haz the power, 2016-04-16 02:08:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-16 02:08:25]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[rkc, 2016-04-16 03:37:50]

The CQ bit was checked by rkc@chromium.org

[commit-bot: I haz the power, 2016-04-16 03:37:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884033002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884033002/60001

[commit-bot: I haz the power, 2016-04-16 23:18:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-16 23:21:09]

Description was changed from

==========
Implement BluetoothTestBlueZ and enable some LE tests.

This CL adds an initial implementation of BluetoothTestBlueZ and enables
some basic x-platform Bluetooth tests. Going foward, any new code written
for Bluetooth, including specifically for BlueZ, should use these test
fixtures.


R=ortuno@chromium.org, scheib@chromium.org
BUG=603368
==========

to

==========
Implement BluetoothTestBlueZ and enable some LE tests.

This CL adds an initial implementation of BluetoothTestBlueZ and enables
some basic x-platform Bluetooth tests. Going foward, any new code written
for Bluetooth, including specifically for BlueZ, should use these test
fixtures.

R=ortuno@chromium.org, scheib@chromium.org
BUG=603368

Committed: https://crrev.com/519a20c6b2f426c891a987289f4da1527531c032
Cr-Commit-Position: refs/heads/master@{#387819}
==========

[commit-bot: I haz the power, 2016-04-16 23:21:10]

Patchset 4 (id:??) landed as
https://crrev.com/519a20c6b2f426c891a987289f4da1527531c032
Cr-Commit-Position: refs/heads/master@{#387819}