Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1884033002: Implement BluetoothTestBlueZ and enable some LE tests. (Closed)

Created:
4 years, 8 months ago by rkc
Modified:
4 years, 8 months ago
Reviewers:
scheib, ortuno
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement BluetoothTestBlueZ and enable some LE tests. This CL adds an initial implementation of BluetoothTestBlueZ and enables some basic x-platform Bluetooth tests. Going foward, any new code written for Bluetooth, including specifically for BlueZ, should use these test fixtures. R=ortuno@chromium.org, scheib@chromium.org BUG=603368 Committed: https://crrev.com/519a20c6b2f426c891a987289f4da1527531c032 Cr-Commit-Position: refs/heads/master@{#387819}

Patch Set 1 #

Patch Set 2 : #

Total comments: 10

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -14 lines) Patch
M device/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_bluez.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_unittest.cc View 1 2 6 chunks +2 lines, -6 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_device_client.h View 1 chunk +11 lines, -0 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_device_client.cc View 1 chunk +35 lines, -0 lines 0 comments Download
A device/bluetooth/test/bluetooth_test_bluez.h View 1 2 3 1 chunk +40 lines, -0 lines 0 comments Download
A device/bluetooth/test/bluetooth_test_bluez.cc View 1 2 3 1 chunk +103 lines, -0 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_win.cc View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M device/device_tests.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (8 generated)
rkc
4 years, 8 months ago (2016-04-14 02:52:31 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884033002/1
4 years, 8 months ago (2016-04-14 03:47:24 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/196626)
4 years, 8 months ago (2016-04-14 04:05:11 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884033002/20001
4 years, 8 months ago (2016-04-14 05:27:09 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 06:25:20 UTC) #9
rkc
ping? This is a fairly small CL, but it sets the direction that I'd write ...
4 years, 8 months ago (2016-04-15 19:05:37 UTC) #10
scheib
https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/bluetooth_adapter_unittest.cc File device/bluetooth/bluetooth_adapter_unittest.cc (right): https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/bluetooth_adapter_unittest.cc#newcode424 device/bluetooth/bluetooth_adapter_unittest.cc:424: InitWithDefaultAdapter(); Skip brining up this test, see below... https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/test/bluetooth_test_bluez.cc ...
4 years, 8 months ago (2016-04-15 19:44:45 UTC) #11
rkc
https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/bluetooth_adapter_unittest.cc File device/bluetooth/bluetooth_adapter_unittest.cc (right): https://codereview.chromium.org/1884033002/diff/20001/device/bluetooth/bluetooth_adapter_unittest.cc#newcode424 device/bluetooth/bluetooth_adapter_unittest.cc:424: InitWithDefaultAdapter(); On 2016/04/15 19:44:44, scheib wrote: > Skip brining ...
4 years, 8 months ago (2016-04-15 20:26:06 UTC) #12
scheib
https://codereview.chromium.org/1884033002/diff/40001/device/bluetooth/test/bluetooth_test_bluez.h File device/bluetooth/test/bluetooth_test_bluez.h (right): https://codereview.chromium.org/1884033002/diff/40001/device/bluetooth/test/bluetooth_test_bluez.h#newcode28 device/bluetooth/test/bluetooth_test_bluez.h:28: void InitWithDefaultAdapter() override; Remove 'InitWithDefaultAdapter' since it isn't implemented ...
4 years, 8 months ago (2016-04-15 21:20:41 UTC) #13
rkc
https://codereview.chromium.org/1884033002/diff/40001/device/bluetooth/test/bluetooth_test_bluez.h File device/bluetooth/test/bluetooth_test_bluez.h (right): https://codereview.chromium.org/1884033002/diff/40001/device/bluetooth/test/bluetooth_test_bluez.h#newcode28 device/bluetooth/test/bluetooth_test_bluez.h:28: void InitWithDefaultAdapter() override; On 2016/04/15 21:20:40, scheib wrote: > ...
4 years, 8 months ago (2016-04-15 21:24:54 UTC) #14
scheib
LGTM
4 years, 8 months ago (2016-04-15 21:40:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884033002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884033002/60001
4 years, 8 months ago (2016-04-16 01:59:59 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/213661) win_clang on tryserver.chromium.win (JOB_FAILED, ...
4 years, 8 months ago (2016-04-16 02:08:25 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884033002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884033002/60001
4 years, 8 months ago (2016-04-16 03:37:55 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-16 23:18:18 UTC) #22
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 23:21:10 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/519a20c6b2f426c891a987289f4da1527531c032
Cr-Commit-Position: refs/heads/master@{#387819}

Powered by Google App Engine
This is Rietveld 408576698