Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1883983003: Remove CSSParserValues (Closed)

Created:
4 years, 8 months ago by rwlbuis
Modified:
4 years, 8 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CSSParserValues Remove CSSParserValues, since the work to make CSSPropertyParser work with CSSParserTokenRange is finished. BUG=499780 Committed: https://crrev.com/e3ed529839cadf60bf3693ffc14e4a6a87e6831c Cr-Commit-Position: refs/heads/master@{#387515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -545 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/css/parser/CSSParserValues.h View 1 chunk +0 lines, -158 lines 0 comments Download
D third_party/WebKit/Source/core/css/parser/CSSParserValues.cpp View 1 chunk +0 lines, -254 lines 0 comments Download
D third_party/WebKit/Source/core/css/parser/CSSParserValuesTest.cpp View 1 chunk +0 lines, -128 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
rwlbuis
PTAL.
4 years, 8 months ago (2016-04-14 17:03:28 UTC) #5
Timothy Loh
On 2016/04/14 17:03:28, rwlbuis wrote: > PTAL. lgtm!!
4 years, 8 months ago (2016-04-14 23:54:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883983003/1
4 years, 8 months ago (2016-04-15 00:25:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 01:45:44 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 01:48:28 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e3ed529839cadf60bf3693ffc14e4a6a87e6831c
Cr-Commit-Position: refs/heads/master@{#387515}

Powered by Google App Engine
This is Rietveld 408576698