Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 1883983002: Roll src/tools/gyp/ 4ec6c4e3a..6ea68631c (3 commits). (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/tools/gyp/ 4ec6c4e3a..6ea68631c (3 commits). https://chromium.googlesource.com/external/gyp.git/+log/4ec6c4e3a94b..6ea68631cdab $ git log 4ec6c4e3a..6ea68631c --date=short --no-merges --format='%ad %ae %s' 2016-04-13 thakis gyp-win-tool: Don't use shell=True on non-Windows hosts. 2016-04-13 thakis gyp-win-tool: Fix regression from my last change. 2016-04-13 thakis gyp-win-tool: Let LinkWrapper only transmogrify / when the host platform is Windows. BUG=495204 R=scottmg@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/c00b76cdbb658e7635e30e49261bbd2f74a394b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Nico
4 years, 8 months ago (2016-04-13 22:43:29 UTC) #1
Nico
4 years, 8 months ago (2016-04-13 22:45:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883983002/1
4 years, 8 months ago (2016-04-13 22:45:56 UTC) #5
scottmg
lgtm
4 years, 8 months ago (2016-04-13 23:10:53 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c00b76cdbb658e7635e30e49261bbd2f74a394b5 Cr-Commit-Position: refs/heads/master@{#387149}
4 years, 8 months ago (2016-04-13 23:43:00 UTC) #10
Nico
4 years, 8 months ago (2016-04-13 23:43:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c00b76cdbb658e7635e30e49261bbd2f74a394b5.

Powered by Google App Engine
This is Rietveld 408576698