Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1883943002: Unused FWL Classes. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Unused FWL Classes. This Cl removes several FWL classes that aren't removed. These include: * IFWL_Content * CFWL_ContentImp * CFWL_CustomPanelImp * CFWL_CustomImp * IFWL_Custom * IFWL_CustomPanel * IFWL_Proxy * CFWL_App BUG=pdfium:468 Committed: https://pdfium.googlesource.com/pdfium/+/ddd5c70e09b6e1db3c01b4900e6424f11fd5c93d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -517 lines) Patch
M BUILD.gn View 4 chunks +1 line, -11 lines 0 comments Download
M xfa.gyp View 3 chunks +0 lines, -8 lines 0 comments Download
D xfa/fwl/core/fwl_contentimp.h View 1 chunk +0 lines, -35 lines 0 comments Download
D xfa/fwl/core/fwl_contentimp.cpp View 1 chunk +0 lines, -94 lines 0 comments Download
M xfa/fwl/core/fwl_formimp.cpp View 3 chunks +0 lines, -10 lines 0 comments Download
M xfa/fwl/core/fwl_panelimp.h View 1 chunk +1 line, -6 lines 0 comments Download
M xfa/fwl/core/fwl_panelimp.cpp View 2 chunks +2 lines, -115 lines 0 comments Download
M xfa/fwl/core/fwl_widgetimp.cpp View 3 chunks +2 lines, -58 lines 0 comments Download
D xfa/fwl/core/ifwl_content.h View 1 chunk +0 lines, -30 lines 0 comments Download
D xfa/fwl/core/ifwl_custom.h View 1 chunk +0 lines, -26 lines 0 comments Download
D xfa/fwl/core/ifwl_custompanel.h View 1 chunk +0 lines, -28 lines 0 comments Download
M xfa/fwl/core/ifwl_panel.h View 1 chunk +0 lines, -9 lines 0 comments Download
D xfa/fwl/core/ifwl_proxy.h View 1 chunk +0 lines, -21 lines 0 comments Download
D xfa/fwl/lightwidget/cfwl_app.h View 1 chunk +0 lines, -31 lines 0 comments Download
D xfa/fwl/lightwidget/cfwl_app.cpp View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-13 21:05:26 UTC) #2
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-13 21:37:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883943002/1
4 years, 8 months ago (2016-04-14 02:03:45 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 02:04:06 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/ddd5c70e09b6e1db3c01b4900e6424f11fd5...

Powered by Google App Engine
This is Rietveld 408576698