Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1883933002: Fix gyp build on ChromeOS for some configurations that are not finding non-skia gfx param traits (Closed)

Created:
4 years, 8 months ago by Mark Dittmer
Modified:
4 years, 8 months ago
Reviewers:
rjkroege, spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, Greg Levin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gyp build on ChromeOS for some configurations that are not finding non-skia gfx param traits BUG=596242 Committed: https://crrev.com/1b5dcb16f8d997aa581e019b5384df4f6fccdf4f Cr-Commit-Position: refs/heads/master@{#387310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/ozone/ozone.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Mark Dittmer
1000 points to you if you can tell my _why_ this is necessary for some ...
4 years, 8 months ago (2016-04-13 20:24:01 UTC) #3
spang
lgtm
4 years, 8 months ago (2016-04-13 20:31:59 UTC) #5
qiangchen
On 2016/04/13 20:24:01, Mark Dittmer wrote: > 1000 points to you if you can tell ...
4 years, 8 months ago (2016-04-13 20:33:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883933002/1
4 years, 8 months ago (2016-04-14 13:57:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 14:29:28 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 14:30:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b5dcb16f8d997aa581e019b5384df4f6fccdf4f
Cr-Commit-Position: refs/heads/master@{#387310}

Powered by Google App Engine
This is Rietveld 408576698