Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: chrome/browser/history/history_service.h

Issue 188393002: HistoryService: clarify documentation about QueryRedirectsCallback behavior. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_service.h
diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h
index cf061deab7a2ec9d345d5a5f96f2df688ed2a7bf..d59675ac247dc176ff254f6ac804fa53edb79ab5 100644
--- a/chrome/browser/history/history_service.h
+++ b/chrome/browser/history/history_service.h
@@ -274,15 +274,18 @@ class HistoryService : public CancelableRequestProvider,
// Called when the results of QueryRedirectsFrom are available.
// The given vector will contain a list of all redirects, not counting
- // the original page. If A redirects to B, the vector will contain only B,
- // and A will be in 'source_url'.
+ // the original page. If A redirects to B which redirects to C, the vector
+ // will contain [B, C], and A will be in 'from_url'.
+ //
+ // For QueryRedirectsTo, the order is reversed. For A->B->C, the vector will
+ // contain [B, A] and C will be in 'to_url'.
//
// If there is no such URL in the database or the most recent visit has no
// redirect, the vector will be empty. If the history system failed for
// some reason, success will additionally be false. If the given page
// has redirected to multiple destinations, this will pick a random one.
typedef base::Callback<void(Handle,
- GURL, // from_url
+ GURL, // from_url / to_url
bool, // success
history::RedirectList*)> QueryRedirectsCallback;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698