Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 1883903002: [Atomics] Handle conversion to SMI in builtin, not code stub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: properly handle signed vs. unsigned Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/code-stubs-arm64.cc » ('j') | src/builtins.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/code-stubs.h" 7 #include "src/code-stubs.h"
8 #include "src/api-arguments.h" 8 #include "src/api-arguments.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 5599 matching lines...) Expand 10 before | Expand all | Expand 10 after
5610 __ b(u32); // Uint32Array 5610 __ b(u32); // Uint32Array
5611 __ b(&abort); // Float32Array 5611 __ b(&abort); // Float32Array
5612 __ b(&abort); // Float64Array 5612 __ b(&abort); // Float64Array
5613 __ b(u8c); // Uint8ClampedArray 5613 __ b(u8c); // Uint8ClampedArray
5614 } 5614 }
5615 5615
5616 __ bind(&abort); 5616 __ bind(&abort);
5617 __ Abort(kNoReason); 5617 __ Abort(kNoReason);
5618 } 5618 }
5619 5619
5620 void ReturnInteger32(MacroAssembler* masm, DwVfpRegister dst, Register value,
5621 SwVfpRegister single_scratch, Label* use_heap_number) {
5622 Label not_smi;
5623 __ TrySmiTag(r0, value, &not_smi);
5624 __ Ret();
5625
5626 __ bind(&not_smi);
5627 __ vmov(single_scratch, value);
5628 __ vcvt_f64_s32(dst, single_scratch);
5629 __ jmp(use_heap_number);
5630 }
5631
5632 void ReturnUnsignedInteger32(MacroAssembler* masm, DwVfpRegister dst,
5633 Register value, SwVfpRegister single_scratch,
5634 Label* use_heap_number) {
5635 Label not_smi;
5636 __ cmp(value, Operand(0x40000000U));
5637 __ b(cs, &not_smi);
5638 __ SmiTag(r0, value);
5639 __ Ret();
5640
5641 __ bind(&not_smi);
5642 __ vmov(single_scratch, value);
5643 __ vcvt_f64_u32(dst, single_scratch);
5644 __ jmp(use_heap_number);
5645 }
5646
5647 void ReturnAllocatedHeapNumber(MacroAssembler* masm, DwVfpRegister value,
5648 Register scratch, Register scratch2,
5649 Register scratch3) {
5650 Label call_runtime;
5651 __ LoadRoot(scratch3, Heap::kHeapNumberMapRootIndex);
5652 __ AllocateHeapNumber(r0, scratch, scratch2, scratch3, &call_runtime);
5653 __ vstr(value, FieldMemOperand(r0, HeapNumber::kValueOffset));
5654 __ Ret();
5655
5656 __ bind(&call_runtime);
5657 {
5658 FrameScope scope(masm, StackFrame::INTERNAL);
5659 __ CallRuntimeSaveDoubles(Runtime::kAllocateHeapNumber);
5660 __ vstr(value, FieldMemOperand(r0, HeapNumber::kValueOffset));
5661 }
5662 __ Ret();
5663 }
5664
5665 } // anonymous namespace 5620 } // anonymous namespace
5666 5621
5667 void AtomicsLoadStub::Generate(MacroAssembler* masm) { 5622 void AtomicsLoadStub::Generate(MacroAssembler* masm) {
5668 Register object = r1; 5623 Register object = r1;
5669 Register index = r0; // Index is an untagged word32. 5624 Register index = r0; // Index is an untagged word32.
5670 Register backing_store = r2; 5625 Register backing_store = r2;
5671 Label i8, u8, i16, u16, i32, u32; 5626 Label i8, u8, i16, u16, i32, u32;
5672 5627
5673 GetTypedArrayBackingStore(masm, backing_store, object, r3, d0); 5628 GetTypedArrayBackingStore(masm, backing_store, object, r3, d0);
5674 TypedArrayJumpTable(masm, object, r3, &i8, &u8, &i16, &u16, &i32, &u32, &u8); 5629 TypedArrayJumpTable(masm, object, r3, &i8, &u8, &i16, &u16, &i32, &u32, &u8);
5675 5630
5676 __ bind(&i8); 5631 __ bind(&i8);
5677 __ ldrsb(r0, MemOperand(backing_store, index)); 5632 __ ldrsb(r0, MemOperand(backing_store, index));
5678 __ dmb(ISH); 5633 __ dmb(ISH);
5679 __ SmiTag(r0);
5680 __ Ret(); 5634 __ Ret();
5681 5635
5682 __ bind(&u8); 5636 __ bind(&u8);
5683 __ ldrb(r0, MemOperand(backing_store, index)); 5637 __ ldrb(r0, MemOperand(backing_store, index));
5684 __ dmb(ISH); 5638 __ dmb(ISH);
5685 __ SmiTag(r0);
5686 __ Ret(); 5639 __ Ret();
5687 5640
5688 __ bind(&i16); 5641 __ bind(&i16);
5689 __ ldrsh(r0, MemOperand(backing_store, index, LSL, 1)); 5642 __ ldrsh(r0, MemOperand(backing_store, index, LSL, 1));
5690 __ dmb(ISH); 5643 __ dmb(ISH);
5691 __ SmiTag(r0);
5692 __ Ret(); 5644 __ Ret();
5693 5645
5694 __ bind(&u16); 5646 __ bind(&u16);
5695 __ ldrh(r0, MemOperand(backing_store, index, LSL, 1)); 5647 __ ldrh(r0, MemOperand(backing_store, index, LSL, 1));
5696 __ dmb(ISH); 5648 __ dmb(ISH);
5697 __ SmiTag(r0);
5698 __ Ret(); 5649 __ Ret();
5699 5650
5700 Label use_heap_number;
5701
5702 __ bind(&i32); 5651 __ bind(&i32);
5703 __ ldr(r0, MemOperand(backing_store, index, LSL, 2)); 5652 __ ldr(r0, MemOperand(backing_store, index, LSL, 2));
5704 __ dmb(ISH); 5653 __ dmb(ISH);
5705 ReturnInteger32(masm, d0, r0, s2, &use_heap_number); 5654 __ Ret();
5706 5655
5707 __ bind(&u32); 5656 __ bind(&u32);
5708 __ ldr(r0, MemOperand(backing_store, index, LSL, 2)); 5657 __ ldr(r0, MemOperand(backing_store, index, LSL, 2));
5709 __ dmb(ISH); 5658 __ dmb(ISH);
5710 ReturnUnsignedInteger32(masm, d0, r0, s2, &use_heap_number); 5659 __ Ret();
5711
5712 __ bind(&use_heap_number);
5713 ReturnAllocatedHeapNumber(masm, d0, r1, r2, r3);
5714 } 5660 }
5715 5661
5716 #undef __ 5662 #undef __
5717 5663
5718 } // namespace internal 5664 } // namespace internal
5719 } // namespace v8 5665 } // namespace v8
5720 5666
5721 #endif // V8_TARGET_ARCH_ARM 5667 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/code-stubs-arm64.cc » ('j') | src/builtins.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698