third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload.html - Issue 1883873002: Do not block document.written scripts in page reloads

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload.html

Issue 1883873002: Do not block document.written scripts in page reloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback incorporated Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload-expected.txt » ('j') | third_party/WebKit/LayoutTests/http/tests/loading/resources/testreload.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script>

	5 // This parameter will be used in testreload.js to indicate reload should

	6 // be from the cache.

	7 var reloadFromCache = false;
	jkarlin 2016/04/14 18:27:01 Instead, how about wrapping the code in testreload Instead, how about wrapping the code in testreload.js in a function and passing this as a parameter? shivanisha 2016/04/14 19:15:44 Changed the reload code for both variants to be in Show quoted text On 2016/04/14 at 18:27:01, jkarlin wrote: > Instead, how about wrapping the code in testreload.js in a function and passing this as a parameter? Changed the reload code for both variants to be in 1 file now, so this variable is no longer needed.
	8 </script>

	9

	10 <script src="./resources/testreload.js"></script>

	11

	12 <script>

	13 test(function () {

	14 assert_true(jsLoaded);

	15 assert_true(loadSuccess);

	16 assert_true(loadBlockedFirst);

	17 }, "cross origin doc.written scripts are not blocked in a page reload");

	18 </script>

OLD	NEW