third_party/WebKit/LayoutTests/http/tests/loading/doc-write-async-third-party-script.html - Issue 1883873002: Do not block document.written scripts in page reloads

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-async-third-party-script.html

Issue 1883873002: Do not block document.written scripts in page reloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed comments from test and added spaces between parameters. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html » ('j') | third_party/WebKit/Source/core/loader/FrameFetchContext.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../resources/testharness.js"></script>	2 <script src="../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="../resources/testharnessreport.js"></script>

4 <script>	4 <script>

5 var t = async_test('Cross origin but asynchronous doc.written scripts are no t blocked');	5 var t = async_test('Cross origin but asynchronous doc.written scripts are no t blocked');

6 var src = 'http://localhost:8000/loading/resources/js-loaded.js?2';	6 var src = 'http://localhost:8000/loading/resources/js-loaded.js?async-third- party-script';

7 var jsLoaded = false;	7 var jsLoaded = false;

8 var loadSuccess = false;	8 var loadSuccess = false;

9 if (window.internals) {	9 if (window.internals) {

10 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrameOnSlow Connections(true);	10 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrameOnSlow Connections(true);

11 internals.setNetworkStateNotifierTestOnly(true);	11 internals.setNetworkStateNotifierTestOnly(true);

12 internals.setNetworkConnectionInfo('cellular2g', 2.0);	12 internals.setNetworkConnectionInfo('cellular2g', 2.0);

13 internals.evictAllResources();	13 internals.evictAllResources();

14	14

15 window.addEventListener('beforeunload', function() {	15 window.addEventListener('beforeunload', function() {

16 internals.setNetworkStateNotifierTestOnly(false);	16 internals.setNetworkStateNotifierTestOnly(false);

17 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrameOn SlowConnections(false);	17 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrameOn SlowConnections(false);

18 }, false);	18 }, false);

19 }	19 }

20 document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true" as ync></scr' + 'ipt>');	20 document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true" as ync></scr' + 'ipt>');

21 </script>	21 </script>

22 <script>	22 <script>

23 window.addEventListener("load", t.step_func(function() {	23 window.addEventListener("load", t.step_func(function() {

24 assert_true(loadSuccess, "Script loaded successfully");	24 assert_true(loadSuccess, "Script loaded successfully");

25 assert_true(jsLoaded, "Cross origin but asynchronous doc.written scripts are not blocked");	25 assert_true(jsLoaded, "Cross origin but asynchronous doc.written scripts are not blocked");

26 t.done();	26 t.done();

27 }));	27 }));

28 </script>	28 </script>

OLD	NEW