Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1883843002: Revert of Work around a bug where create_bundle() is ignoring data_deps() in iOS GN build. (Closed)

Created:
4 years, 8 months ago by sdefresne
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
brettw, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Work around a bug where create_bundle() is ignoring data_deps() in iOS GN build. (patchset #1 id:1 of https://codereview.chromium.org/1845753002/ ) Reason for revert: gn binary as been fixed and create_bundle now causes its data_deps to be built, reverting this temporary change. Original issue's description: > Work around a bug where create_bundle() is ignoring data_deps() in iOS GN build. > > It looks like create_bundle() is not checking for data_deps when it > generates its ninja rules, and as a result we don't build iossim > when we build base_unittests.app. By shifting the data_dep to the > underlying executable target, this works around the issue, but we > should probably fix the GN code generator for create_bundle() instead. > > R=sdefresne@chromium.org > BUG=599203 > > Committed: https://crrev.com/cd03fa72212077a789679a77992529c3aa6c08fe > Cr-Commit-Position: refs/heads/master@{#384141} TBR=dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=599203 Committed: https://crrev.com/d76422e697ad4de2edac5b23f12da1ee5e9dcd56 Cr-Commit-Position: refs/heads/master@{#386994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M build/config/ios/rules.gni View 2 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
sdefresne
Created Revert of Work around a bug where create_bundle() is ignoring data_deps() in iOS GN ...
4 years, 8 months ago (2016-04-13 14:27:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883843002/1
4 years, 8 months ago (2016-04-13 14:27:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883843002/1
4 years, 8 months ago (2016-04-13 14:31:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883843002/1
4 years, 8 months ago (2016-04-13 15:01:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 15:14:15 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d76422e697ad4de2edac5b23f12da1ee5e9dcd56 Cr-Commit-Position: refs/heads/master@{#386994}
4 years, 8 months ago (2016-04-13 15:16:43 UTC) #7
Dirk Pranke
4 years, 8 months ago (2016-04-14 00:47:09 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698