DescriptionRevert of Work around a bug where create_bundle() is ignoring data_deps() in iOS GN build. (patchset #1 id:1 of https://codereview.chromium.org/1845753002/ )
Reason for revert:
gn binary as been fixed and create_bundle now causes its data_deps to be built, reverting this temporary change.
Original issue's description:
> Work around a bug where create_bundle() is ignoring data_deps() in iOS GN build.
>
> It looks like create_bundle() is not checking for data_deps when it
> generates its ninja rules, and as a result we don't build iossim
> when we build base_unittests.app. By shifting the data_dep to the
> underlying executable target, this works around the issue, but we
> should probably fix the GN code generator for create_bundle() instead.
>
> R=sdefresne@chromium.org
> BUG=599203
>
> Committed: https://crrev.com/cd03fa72212077a789679a77992529c3aa6c08fe
> Cr-Commit-Position: refs/heads/master@{#384141}
TBR=dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=599203
Committed: https://crrev.com/d76422e697ad4de2edac5b23f12da1ee5e9dcd56
Cr-Commit-Position: refs/heads/master@{#386994}
Patch Set 1 #
Messages
Total messages: 8 (1 generated)
|