Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1883823002: Revert of clang/win: Stop passing -Qunused-arguments in pdfium too. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com, Oliver Chang
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of clang/win: Stop passing -Qunused-arguments in pdfium too. (patchset #1 id:1 of https://codereview.chromium.org/1887643002/ ) Reason for revert: pdfium still passes /GS Original issue's description: > clang/win: Stop passing -Qunused-arguments in pdfium too. > > We stopped passing this in Chromium a while ago. > > BUG=504658 > > Committed: https://pdfium.googlesource.com/pdfium/+/112be9813ed7bf4e082048eda5f4a7d3837d116c TBR=thestig@chromium.org,dsinclair@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504658 Committed: https://pdfium.googlesource.com/pdfium/+/a364fad07e5baf4a72ea734e64fb55664cab075e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/standalone.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Nico
Created Revert of clang/win: Stop passing -Qunused-arguments in pdfium too.
4 years, 8 months ago (2016-04-13 13:19:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883823002/1
4 years, 8 months ago (2016-04-13 13:19:39 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 13:19:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/a364fad07e5baf4a72ea734e64fb55664cab...

Powered by Google App Engine
This is Rietveld 408576698