Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1883813005: Add shortcuts to audio player. (Closed)

Created:
4 years, 8 months ago by oka
Modified:
4 years, 8 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add shortcuts to audio player. Space, K - pause Down/Up or Left/Right - rewind/forward min(5s, 10% of the duration). J/L - rewind/forward min(10s, 20% of the duration). BUG=214861 Committed: https://crrev.com/d03ae7a55e5f914eff4683634cc13354ceb1eac1 Cr-Commit-Position: refs/heads/master@{#387257}

Patch Set 1 #

Patch Set 2 : Nit comments. #

Total comments: 2

Patch Set 3 : Address comments #

Patch Set 4 : Revert 'send to start when paused' for now. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -28 lines) Patch
M ui/file_manager/audio_player/elements/control_panel.js View 1 2 3 3 chunks +34 lines, -28 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player.js View 1 2 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
oka
Nit comments.
4 years, 8 months ago (2016-04-14 05:10:56 UTC) #1
oka
PTAL
4 years, 8 months ago (2016-04-14 05:11:27 UTC) #2
oka
PTAL
4 years, 8 months ago (2016-04-14 05:11:39 UTC) #4
fukino
https://codereview.chromium.org/1883813005/diff/20001/ui/file_manager/audio_player/js/audio_player.js File ui/file_manager/audio_player/js/audio_player.js (right): https://codereview.chromium.org/1883813005/diff/20001/ui/file_manager/audio_player/js/audio_player.js#newcode376 ui/file_manager/audio_player/js/audio_player.js:376: case 'Right': Please keep the behaviors on Up/Down.
4 years, 8 months ago (2016-04-14 05:42:47 UTC) #5
oka
Address comments
4 years, 8 months ago (2016-04-14 05:55:25 UTC) #7
oka
PTAL https://codereview.chromium.org/1883813005/diff/20001/ui/file_manager/audio_player/js/audio_player.js File ui/file_manager/audio_player/js/audio_player.js (right): https://codereview.chromium.org/1883813005/diff/20001/ui/file_manager/audio_player/js/audio_player.js#newcode376 ui/file_manager/audio_player/js/audio_player.js:376: case 'Right': On 2016/04/14 05:42:47, fukino wrote: > ...
4 years, 8 months ago (2016-04-14 05:55:30 UTC) #8
oka
Revert 'send to start when paused' for now.
4 years, 8 months ago (2016-04-14 06:03:50 UTC) #9
oka
PTAL
4 years, 8 months ago (2016-04-14 06:05:02 UTC) #11
fukino
lgtm
4 years, 8 months ago (2016-04-14 06:52:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883813005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883813005/60001
4 years, 8 months ago (2016-04-14 07:05:40 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-14 07:45:17 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 07:47:37 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d03ae7a55e5f914eff4683634cc13354ceb1eac1
Cr-Commit-Position: refs/heads/master@{#387257}

Powered by Google App Engine
This is Rietveld 408576698