Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 18838002: Add a test case for Phi representations (Closed)

Created:
7 years, 5 months ago by Jakob Kummerow
Modified:
7 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Add a test case for Phi representations BUG=chromium:167394 R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15553

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
A + test/mjsunit/compiler/phi-representations.js View 1 chunk +24 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL. The first test (function "ar") is broken in 3.18 and earlier branches, the second ...
7 years, 5 months ago (2013-07-08 11:07:37 UTC) #1
Toon Verwaest
lgtm
7 years, 5 months ago (2013-07-08 13:06:43 UTC) #2
Jakob Kummerow
7 years, 5 months ago (2013-07-08 13:43:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15553 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698