Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1883773003: Simplify SVGElement::addToPropertyMap (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr., f(malita)
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify SVGElement::addToPropertyMap Shaves a few instructions off (most prominently a call to the QualifiedName destructor.) Committed: https://crrev.com/607a5cee21d9bcfe16a34c7d8d977bea98d52af7 Cr-Commit-Position: refs/heads/master@{#387024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
fs
4 years, 8 months ago (2016-04-13 15:07:51 UTC) #3
f(malita)
lgtm
4 years, 8 months ago (2016-04-13 15:33:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883773003/1
4 years, 8 months ago (2016-04-13 15:35:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 17:55:01 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 17:56:37 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/607a5cee21d9bcfe16a34c7d8d977bea98d52af7
Cr-Commit-Position: refs/heads/master@{#387024}

Powered by Google App Engine
This is Rietveld 408576698