Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1630)

Unified Diff: chrome/test/BUILD.gn

Issue 1883723004: Android: Avoid linking with --gc-sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: back to patch set 3 Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index e8e59bc6701b97b2f1822d999da226b578891a2b..646a486a7ef77a6dcec4ed224b62c7b65c4dab1d 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -1674,7 +1674,6 @@ test("unit_tests") {
"//components/webdata_services:test_support",
"//content/app/resources",
"//device/bluetooth:mocks",
- "//device/core:mocks",
"//device/usb:mocks",
"//gpu:test_support",
"//media:test_support",
@@ -1709,10 +1708,6 @@ test("unit_tests") {
"//chrome/test/android/unit_tests_apk/AndroidManifest.xml"
enable_multidex = true
isolate_file = "../unit_tests.isolate"
-
- # Some android targets still depend on --gc-sections to link.
- # TODO: remove --gc-sections for Debug builds (crbug.com/159847).
- ldflags = [ "-Wl,--gc-sections" ]
} else {
sources += rebase_path(
chrome_tests_unit_gypi_values.chrome_unit_tests_non_android_sources,
@@ -1781,6 +1776,8 @@ test("unit_tests") {
deps += [
"//chrome/common/extensions/api",
"//components/audio_modem:test_support",
+ "//device/core:mocks",
+ "//device/hid:mocks",
"//extensions:extensions_resources",
"//extensions/strings",
]
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698