Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1883723002:
Sort layer tree paint invalidations by all fields (Closed)
|
Created:
4 years, 8 months ago by Xianzhu Modified:
4 years, 8 months ago Reviewers:
pdr. CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSort layer tree paint invalidations by all fields
Some test may generate paint invalidtion items in random sequence
(e.g. for svg/filters/filter-refresh.svg the order of original paint
invalidation items depends on the iteration order of a HashMap).
We must sort the result by all fields to make the tests generate
stable result across runs.
BUG=602483
Committed: https://crrev.com/be0bbb8f0bdc73f6123f7713311e6cd5541b0d14
Cr-Commit-Position: refs/heads/master@{#387470}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : NeedsRebaselines #Patch Set 4 : #
Messages
Total messages: 22 (13 generated)
Description was changed from ========== Sort layer tree paint invalidations by all fields Some test may generate paint invalidtion items in random sequence (e.g. for svg/filters/filter-refresh.svg the order of original paint invalidation items depends on the iteration order of a HashMap). We must sort the result by all fields to make the tests generate stable result across runs. BUG=602483 ========== to ========== Sort layer tree paint invalidations by all fields Some test may generate paint invalidtion items in random sequence (e.g. for svg/filters/filter-refresh.svg the order of original paint invalidation items depends on the iteration order of a HashMap). We must sort the result by all fields to make the tests generate stable result across runs. BTW, don't merge invalidateDisplayItemClient() entries into setNeedsDisplayInRect() entries, because 1. it's not feasible to do this with the new sorting method; 2. the merge made we lost the test coverage of invalidateDisplayItemClient() in some cases, e.g. an object is invalidated a rect, but we forget to invalidate its display items. BUG=602483 ==========
wangxianzhu@chromium.org changed reviewers: + pdr@chromium.org
Message was sent while issue was closed.
Description was changed from ========== Sort layer tree paint invalidations by all fields Some test may generate paint invalidtion items in random sequence (e.g. for svg/filters/filter-refresh.svg the order of original paint invalidation items depends on the iteration order of a HashMap). We must sort the result by all fields to make the tests generate stable result across runs. BTW, don't merge invalidateDisplayItemClient() entries into setNeedsDisplayInRect() entries, because 1. it's not feasible to do this with the new sorting method; 2. the merge made we lost the test coverage of invalidateDisplayItemClient() in some cases, e.g. an object is invalidated a rect, but we forget to invalidate its display items. BUG=602483 ========== to ========== Sort layer tree paint invalidations by all fields Some test may generate paint invalidtion items in random sequence (e.g. for svg/filters/filter-refresh.svg the order of original paint invalidation items depends on the iteration order of a HashMap). We must sort the result by all fields to make the tests generate stable result across runs. BTW, don't merge invalidateDisplayItemClient() entries into setNeedsDisplayInRect() entries, because 1. it's not feasible to do this with the new sorting method; 2. the merge made we lost the test coverage of invalidateDisplayItemClient() in some cases, e.g. an object is invalidated a rect, but we forget to invalidate its display items. BUG=602483 ==========
Description was changed from ========== Sort layer tree paint invalidations by all fields Some test may generate paint invalidtion items in random sequence (e.g. for svg/filters/filter-refresh.svg the order of original paint invalidation items depends on the iteration order of a HashMap). We must sort the result by all fields to make the tests generate stable result across runs. BTW, don't merge invalidateDisplayItemClient() entries into setNeedsDisplayInRect() entries, because 1. it's not feasible to do this with the new sorting method; 2. the merge made we lost the test coverage of invalidateDisplayItemClient() in some cases, e.g. an object is invalidated a rect, but we forget to invalidate its display items. BUG=602483 ========== to ========== Sort layer tree paint invalidations by all fields Some test may generate paint invalidtion items in random sequence (e.g. for svg/filters/filter-refresh.svg the order of original paint invalidation items depends on the iteration order of a HashMap). We must sort the result by all fields to make the tests generate stable result across runs. BUG=602483 ==========
LGTM. Had to learn about strict weak ordering but I think this code is correct.
The CQ bit was checked by wangxianzhu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org Link to the patchset: https://codereview.chromium.org/1883723002/#ps40001 (title: "NeedsRebaselines")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883723002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by wangxianzhu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org Link to the patchset: https://codereview.chromium.org/1883723002/#ps60001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883723002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883723002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883723002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883723002/60001
Message was sent while issue was closed.
Description was changed from ========== Sort layer tree paint invalidations by all fields Some test may generate paint invalidtion items in random sequence (e.g. for svg/filters/filter-refresh.svg the order of original paint invalidation items depends on the iteration order of a HashMap). We must sort the result by all fields to make the tests generate stable result across runs. BUG=602483 ========== to ========== Sort layer tree paint invalidations by all fields Some test may generate paint invalidtion items in random sequence (e.g. for svg/filters/filter-refresh.svg the order of original paint invalidation items depends on the iteration order of a HashMap). We must sort the result by all fields to make the tests generate stable result across runs. BUG=602483 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Sort layer tree paint invalidations by all fields Some test may generate paint invalidtion items in random sequence (e.g. for svg/filters/filter-refresh.svg the order of original paint invalidation items depends on the iteration order of a HashMap). We must sort the result by all fields to make the tests generate stable result across runs. BUG=602483 ========== to ========== Sort layer tree paint invalidations by all fields Some test may generate paint invalidtion items in random sequence (e.g. for svg/filters/filter-refresh.svg the order of original paint invalidation items depends on the iteration order of a HashMap). We must sort the result by all fields to make the tests generate stable result across runs. BUG=602483 Committed: https://crrev.com/be0bbb8f0bdc73f6123f7713311e6cd5541b0d14 Cr-Commit-Position: refs/heads/master@{#387470} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/be0bbb8f0bdc73f6123f7713311e6cd5541b0d14 Cr-Commit-Position: refs/heads/master@{#387470} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
