Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1883703002: Revert "Notifies the IME extension for IME ready with onActivate/onFocus events at start." (Closed)

Created:
4 years, 8 months ago by Azure Wei
Modified:
4 years, 8 months ago
Reviewers:
Shu Chen
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Notifies the IME extension for IME ready with onActivate/onFocus events at start." This reverts commit 96e3d965e31d8a9d794dc9b8c046467223a3ec6f. BUG=517773 TEST=None Committed: https://crrev.com/80bdf34b301cb2dfeaffec14909afcee904d941b Cr-Commit-Position: refs/heads/master@{#386907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Azure Wei
Please review this cl. Thanks!
4 years, 8 months ago (2016-04-13 02:08:24 UTC) #3
Shu Chen
lgtm
4 years, 8 months ago (2016-04-13 02:08:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883703002/1
4 years, 8 months ago (2016-04-13 02:09:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 02:50:01 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 02:51:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80bdf34b301cb2dfeaffec14909afcee904d941b
Cr-Commit-Position: refs/heads/master@{#386907}

Powered by Google App Engine
This is Rietveld 408576698