Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/lib/typed_data.dart

Issue 18837002: Move toString() to collection classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/lib/growable_array.dart ('K') | « runtime/lib/growable_array.dart ('k') | sdk/lib/_collection_dev/iterable.dart » ('j') | sdk/lib/_collection_dev/iterable.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/typed_data.dart
diff --git a/runtime/lib/typed_data.dart b/runtime/lib/typed_data.dart
index 04f6fa9b1229889a77989c35b0e30d7336d67f60..98542bc74f4c7e2097cbf644e5cdf81a7c56d28f 100644
--- a/runtime/lib/typed_data.dart
+++ b/runtime/lib/typed_data.dart
@@ -279,6 +279,7 @@ patch class ByteData {
// the collection and list interfaces.
abstract class _TypedListBase {
+
// Method(s) implementing the Collection interface.
bool contains(element) => IterableMixinWorkaround.contains(this, element);
@@ -505,10 +506,9 @@ abstract class _TypedListBase {
// Method(s) implementing Object interface.
String toString() {
- return ToString.iterableToString(this);
+ return IterableMixinWorkaround.toStringList(this);
}
-
Lasse Reichstein Nielsen 2013/07/09 06:15:44 Why remove line?
zarah 2013/07/09 08:20:54 Added back.
// Internal utility methods.
bool _setRange(int start, int length, Iterable from, int startFrom)
« runtime/lib/growable_array.dart ('K') | « runtime/lib/growable_array.dart ('k') | sdk/lib/_collection_dev/iterable.dart » ('j') | sdk/lib/_collection_dev/iterable.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698