sdk/lib/collection/linked_list.dart - Issue 18837002: Move toString() to collection classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/collection/linked_list.dart

Issue 18837002: Move toString() to collection classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/collection/linked_list.dart

diff --git a/sdk/lib/collection/linked_list.dart b/sdk/lib/collection/linked_list.dart

index a9c898969429e27cbe854b7cf577c6acfb06c7bc..cec551309de4a7db9a4410f5a49d4393e9fa4bc9 100644

--- a/sdk/lib/collection/linked_list.dart

+++ b/sdk/lib/collection/linked_list.dart

@@ -14,6 +14,7 @@ part of dart.collection;

class LinkedList<E extends LinkedListEntry<E>>

extends IterableBase<E>

implements _LinkedListLink {

int _modificationCount = 0;

int _length = 0;

_LinkedListLink _next;

@@ -60,7 +61,8 @@ class LinkedList<E extends LinkedListEntry<E>>

Iterator<E> get iterator => new _LinkedListIterator<E>(this);

- String toString() => ToString.iterableToString(this);

+ //TODO Remove this, and let it be inherited by IterableMixin

floitsch 2013/07/08 16:12:34 Add space after "//". TODOS are always of the form

zarah 2013/07/08 16:57:46 Done.

+ String toString() => IterableMixinWorkaround.toStringIterable(this);

int get length => _length;