sdk/lib/_internal/lib/js_array.dart - Issue 18837002: Move toString() to collection classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/js_array.dart

Issue 18837002: Move toString() to collection classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/lib/js_array.dart

diff --git a/sdk/lib/_internal/lib/js_array.dart b/sdk/lib/_internal/lib/js_array.dart

index 36685a4be65a7c3bc8f65822d1d1ad33ad6be298..ff967dd79df26ac471ac71242b7401cd4c9f4e5f 100644

--- a/sdk/lib/_internal/lib/js_array.dart

+++ b/sdk/lib/_internal/lib/js_array.dart

@@ -11,6 +11,7 @@ part of _interceptors;

* argument added to each member.

class JSArray<E> extends Interceptor implements List<E>, JSIndexable {

const JSArray();

checkMutable(reason) {

@@ -261,8 +262,8 @@ class JSArray<E> extends Interceptor implements List<E>, JSIndexable {

bool get isNotEmpty => !isEmpty;

- String toString() => ToString.iterableToString(this);

+ String toString() => IterableMixinWorkaround.toStringList(this);

List<E> toList({ bool growable: true }) =>

new List<E>.from(this, growable: growable);