Move toString() to collection classes.

sdk/lib/_collection_dev/iterable.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart._collection.dev;
 
 
 // This is a hack to make @deprecated work in dart:io. Don't remove or use this,
 // unless coordinated with either me or the core library team. Thanks!
 // TODO(ajohnsen): Remove at the 11th of Auguest 2013.
@@ skipping 684 matching lines @@
 abstract class BidirectionalIterator<T> implements Iterator<T> {
   bool movePrevious();
 }
 
 /**
  * This class provides default implementations for Iterables (including Lists).
  *
  * The uses of this class will be replaced by mixins.
  */
 class IterableMixinWorkaround {
+  // A list to identify cyclic collections during toString() calls. 
+  static List _toStringList = new List();
+  
   static bool contains(Iterable iterable, var element) {
     for (final e in iterable) {
       if (e == element) return true;
     }
     return false;
   }
 
   static void forEach(Iterable iterable, void f(o)) {
     for (final e in iterable) {
       f(e);
@@ skipping 173 matching lines @@
     } else {
       buffer.write(list[0]);
       for (int i = 1; i < list.length; i++) {
         buffer.write(separator);
         buffer.write(list[i]);
       }
     }
     return buffer.toString();
   }
 
+  static String toStringIterable(Iterable iterable) {
+    for (int i = 0; i < _toStringList.length; i++) {
+      if (identical(_toStringList[i], iterable)) { return '{...}'; }
+    }
+    
+    var result = new StringBuffer();

[floitsch, 2013/07/08 16:12:34]

Type variable.

[zarah, 2013/07/08 16:57:46]

Done.

+    try {
+      _toStringList.add(iterable);
+      result.write('{');
+      bool first = true;
+      for (var e in iterable) {

[floitsch, 2013/07/08 16:12:34]

You could see, if iterable.join(", ") doesn't cost too much.

[zarah, 2013/07/08 16:57:46]

Use writeAll instead since it is cheaper.

+        if (!first) {
+          result.write(', ');
+        }
+        first = false;
+        result.write(e);
+      }
+      result.write('}');
+    } finally {

[floitsch, 2013/07/08 16:12:34]

assert that you are the last.

[zarah, 2013/07/08 16:57:46]

Done.

+      _toStringList.removeLast();
+    }
+    return result.toString();      
+  }
+  
+  static String toStringList(List list) {
+    for (int i = 0; i < _toStringList.length; i++) {
+      if (identical(_toStringList[i], list)) { return '[...]'; }
+    }
+
+    var result = new StringBuffer();
+    try {
+      _toStringList.add(list);
+      result.write('[');
+      for (int i = 0; i < list.length; i++) {

[floitsch, 2013/07/08 16:12:34]

ditto. If list.join(", ") isn't too expensive it would remove code duplication.

[zarah, 2013/07/08 16:57:46]

Use writeAll instead since it is cheaper.

+        if (i > 0) {
+          result.write(', ');
+        }
+        result.write(list[i]);
+      }
+      result.write(']');
+     } finally {
+        _toStringList.removeLast();  
+     }
+     
+    return result.toString();
+  }
+
   static Iterable where(Iterable iterable, bool f(var element)) {
     return new WhereIterable(iterable, f);
   }
 
   static Iterable map(Iterable iterable, f(var element)) {
     return new MappedIterable(iterable, f);
   }
 
   static Iterable mapList(List list, f(var element)) {
     return new MappedListIterable(list, f);
@@ skipping 156 matching lines @@
 
   static Set setDifference(Set set, Set other, Set result) {
     for (var element in set) {
       if (!other.contains(element)) {
         result.add(element);
       }
     }
     return result;
   }
 }