Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: runtime/lib/growable_array.dart

Issue 18837002: Move toString() to collection classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 class _GrowableObjectArray<T> implements List<T> { 5 class _GrowableObjectArray<T> implements List<T> {
6 static final int _classId = (new _GrowableObjectArray(0))._cid; 6 static final int _classId = (new _GrowableObjectArray(0))._cid;
7 7
8 void insert(int index, T element) { 8 void insert(int index, T element) {
9 if (index < 0 || index > length) { 9 if (index < 0 || index > length) {
10 throw new RangeError.range(index, 0, length); 10 throw new RangeError.range(index, 0, length);
(...skipping 318 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 void clear() { 329 void clear() {
330 this.length = 0; 330 this.length = 0;
331 } 331 }
332 332
333 Iterable<T> get reversed => IterableMixinWorkaround.reversedList(this); 333 Iterable<T> get reversed => IterableMixinWorkaround.reversedList(this);
334 334
335 void sort([int compare(T a, T b)]) { 335 void sort([int compare(T a, T b)]) {
336 IterableMixinWorkaround.sortList(this, compare); 336 IterableMixinWorkaround.sortList(this, compare);
337 } 337 }
338 338
339 String toString() { 339 String toString() => IterableMixinWorkaround.toStringList(this);
floitsch 2013/07/08 16:12:34 VM devs prefer not to use "=>".
zarah 2013/07/08 16:57:46 Done.
340 return ToString.iterableToString(this); 340
341 }
342
343 Iterator<T> get iterator { 341 Iterator<T> get iterator {
344 return new ListIterator<T>(this); 342 return new ListIterator<T>(this);
345 } 343 }
346 344
347 List<T> toList({ bool growable: true }) { 345 List<T> toList({ bool growable: true }) {
348 return new List<T>.from(this, growable: growable); 346 return new List<T>.from(this, growable: growable);
349 } 347 }
350 348
351 Set<T> toSet() { 349 Set<T> toSet() {
352 return new Set<T>.from(this); 350 return new Set<T>.from(this);
353 } 351 }
354 352
355 Map<int, T> asMap() { 353 Map<int, T> asMap() {
356 return IterableMixinWorkaround.asMapList(this); 354 return IterableMixinWorkaround.asMapList(this);
357 } 355 }
358 } 356 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698