Move toString() to collection classes.

sdk/lib/_internal/lib/js_array.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of _interceptors;
 
 /**
  * The interceptor class for [List]. The compiler recognizes this
  * class as an interceptor, and changes references to [:this:] to
  * actually use the receiver of the method, which is generated as an extra
  * argument added to each member.
  */
 class JSArray<E> extends Interceptor implements List<E>, JSIndexable {
+
+  static List _toStringList = new List();
+  
   const JSArray();
 
   checkMutable(reason) {
     if (this is !JSMutableArray) { 
       throw new UnsupportedError(reason);
     }
   }
 
   checkGrowable(reason) {
     if (this is !JSExtendableArray) {
@@ skipping 230 matching lines @@
     for (int i = 0; i < length; i++) {
       if (this[i] == other) return true;
     }
     return false;
   }
 
   bool get isEmpty => length == 0;
 
   bool get isNotEmpty => !isEmpty;
 
-  String toString() => ToString.iterableToString(this);
-
+  String toString() {

[floitsch, 2013/07/08 12:00:50]

change to IterableMixinWorkaround.toStringList(this);

[zarah, 2013/07/08 14:35:15]

Done.

+    for(int i = 0; i < _toStringList.length; i++) {
+      if(identical(_toStringList[i], this))
+          return '[...]';
+    }
+    _toStringList.add(this);
+    String result = IterableMixinWorkaround.toStringList(this);
+    _toStringList.remove(this);
+    return result;
+  }
+  
   List<E> toList({ bool growable: true }) =>
       new List<E>.from(this, growable: growable);
 
   Set<E> toSet() => new Set<E>.from(this);
 
   Iterator<E> get iterator => new ListIterator<E>(this);
 
   int get hashCode => Primitives.objectHashCode(this);
 
   int get length => JS('int', r'#.length', this);
@@ skipping 24 matching lines @@
 }
 
 /**
  * Dummy subclasses that allow the backend to track more precise
  * information about arrays through their type. The CPA type inference
  * relies on the fact that these classes do not override [] nor []=.
  */
 class JSMutableArray extends JSArray implements JSMutableIndexable {}
 class JSFixedArray extends JSMutableArray {}
 class JSExtendableArray extends JSMutableArray {}