Move toString() to collection classes.

sdk/lib/_collection_dev/iterable.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart._collection.dev;
 
 
 // This is a hack to make @deprecated work in dart:io. Don't remove or use this,
 // unless coordinated with either me or the core library team. Thanks!
 // TODO(ajohnsen): Remove at the 11th of Auguest 2013.
@@ skipping 877 matching lines @@
     } else {
       buffer.write(list[0]);
       for (int i = 1; i < list.length; i++) {
         buffer.write(separator);
         buffer.write(list[i]);
       }
     }
     return buffer.toString();
   }
 
+  static String toStringIterable(Iterable iterable) {
+    var result = new StringBuffer();

[floitsch, 2013/07/08 12:00:50]

Move checking of recursive iterables in here.

[zarah, 2013/07/08 14:35:15]

Done.

+
+    result.write('{');
+    bool first = true;
+    for (var e in iterable) {
+      if (!first) {
+        result.write(', ');
+      }
+      first = false;
+      result.write(e);
+    }
+    result.write('}');
+      
+    return result.toString();      
+  }
+  
+  static String toStringList(List list) {

[floitsch, 2013/07/08 12:00:50]

Move checking of recursive lists in here.

[zarah, 2013/07/08 14:35:15]

Done.

+    var result = new StringBuffer();
+    result.write('[');
+    for (int i = 0; i < list.length; i++) {
+      if (i > 0) {
+        result.write(', ');
+      }
+      result.write(list[i]);
+    }
+    result.write(']');
+    
+    return result.toString();
+  }
+ 
+
   static Iterable where(Iterable iterable, bool f(var element)) {
     return new WhereIterable(iterable, f);
   }
 
   static Iterable map(Iterable iterable, f(var element)) {
     return new MappedIterable(iterable, f);
   }
 
   static Iterable mapList(List list, f(var element)) {
     return new MappedListIterable(list, f);
@@ skipping 67 matching lines @@
     // TODO(floitsch): Make this accept more.
     List otherList;
     int otherStart;
     if (from is List) {
       otherList = from;
       otherStart = skipCount;
     } else {
       otherList = from.skip(skipCount).toList(growable: false);
       otherStart = 0;
     }
+    
     if (otherStart + length > otherList.length) {
       throw new StateError("Not enough elements");
     }
     Arrays.copy(otherList, otherStart, list, start, length);
   }
 
   static void replaceRangeList(List list, int start, int end,
                                Iterable iterable) {
     _rangeCheck(list, start, end);
     // TODO(floitsch): optimize this.
@@ skipping 69 matching lines @@
 
   static Set setDifference(Set set, Set other, Set result) {
     for (var element in set) {
       if (!other.contains(element)) {
         result.add(element);
       }
     }
     return result;
   }
 }