Move toString() to collection classes.

runtime/lib/typed_data.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // patch classes for Int8List ..... Float64List and ByteData implementations.
 
 patch class Int8List {
   /* patch */ factory Int8List(int length) {
     return new _Int8Array(length);
   }
@@ skipping 261 matching lines @@
     }
     return new _ByteDataView(buffer, offsetInBytes, length);
   }
 }
 
 
 // Based class for _TypedList that provides common methods for implementing
 // the collection and list interfaces.
 
 abstract class _TypedListBase {
+  static List _toStringList = new List();
+  
   // Method(s) implementing the Collection interface.
   bool contains(element) => IterableMixinWorkaround.contains(this, element);
 
   void forEach(void f(num element)) {
     var len = this.length;
     for (var i = 0; i < len; i++) {
       f(this[i]);
     }
   }
 
@@ skipping 205 matching lines @@
     IterableMixinWorkaround.setAllList(this, index, iterable);
   }
 
   void fillRange(int start, int end, [num fillValue]) {
     IterableMixinWorkaround.fillRangeList(this, start, end, fillValue);
   }
 
 
   // Method(s) implementing Object interface.
 
   String toString() {

[floitsch, 2013/07/08 12:00:50]

change to IterableMixinWorkaround.toStringList(this);

[zarah, 2013/07/08 14:35:15]

Done.

-    return ToString.iterableToString(this);
+    for(int i = 0; i < _toStringList.length; i++) {
+      if(identical(_toStringList[i], this))
+          return '[...]';
+    }
+    _toStringList.add(this);
+    String result = IterableMixinWorkaround.toStringList(this);
+    _toStringList.remove(this);
+    return result;
   }
 
-
   // Internal utility methods.
 
   bool _setRange(int start, int length, Iterable from, int startFrom)
       native "TypedData_setRange";
 }
 
 
 abstract class _TypedList extends _TypedListBase implements ByteBuffer {
   // Default method implementing parts of the TypedData interface.
   int get offsetInBytes {
@@ skipping 2584 matching lines @@
     return value;
   }
   return object;
 }
 
 
 void _throwRangeError(int index, int length) {
   String message = "$index must be in the range [0..$length)";
   throw new RangeError(message);
 }