Move toString() to collection classes.

runtime/lib/array.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 // TODO(srdjan): Use shared array implementation.
 class _ObjectArray<E> implements List<E> {
   static final int _classId = (new _ObjectArray(0))._cid;
+  
+  static List _toStringList = new List();

[floitsch, 2013/07/08 12:00:50]

Add comment what this does.

[zarah, 2013/07/08 14:35:15]

Done.

 
   factory _ObjectArray(length) native "ObjectArray_allocate";
 
   E operator [](int index) native "ObjectArray_getIndexed";
 
   void operator []=(int index, E value) native "ObjectArray_setIndexed";
 
   String toString() {
-    return ToString.iterableToString(this);
+    for(int i = 0; i < _toStringList.length; i++) {

[floitsch, 2013/07/08 12:00:50]

Change the call to `ToString.iterableToString` to
IterableMixinWorkaround.toStringList(), but otherwise keep the function.

Let the IterableMixinWorkaround deal with recursive lists.

[zarah, 2013/07/08 14:35:15]

Done.

+      if(identical(_toStringList[i], this))

[floitsch, 2013/07/08 12:00:50]

Multiline `if`s always have {} for the body.
You can put it one one line, though.

[zarah, 2013/07/08 14:35:15]

Done.

+          return '[...]';
+    }
+    _toStringList.add(this);
+    String result = IterableMixinWorkaround.toStringList(this);
+    _toStringList.remove(this);

[floitsch, 2013/07/08 12:00:50]

You need to guard the removal with a `finally`. (Also add test for this case).
You must be the last one, otherwise something went wrong.
assert it, and then simply `removeLast`.

[zarah, 2013/07/08 14:35:15]

Done.

+    return result;
   }
-
+  
   int get length native "ObjectArray_getLength";
 
   void _copyFromObjectArray(_ObjectArray src,
                             int srcStart,
                             int dstStart,
                             int count)
       native "ObjectArray_copyFromObjectArray";
 
   void insert(int index, E element) {
     throw new UnsupportedError(
@@ skipping 242 matching lines @@
 
 // This is essentially the same class as _ObjectArray, but it does not
 // permit any modification of array elements from Dart code. We use
 // this class for arrays constructed from Dart array literals.
 // TODO(hausner): We should consider the trade-offs between two
 // classes (and inline cache misses) versus a field in the native
 // implementation (checks when modifying). We should keep watching
 // the inline cache misses.
 class _ImmutableArray<E> implements List<E> {
   static final int _classId = (const [])._cid;
+  static List _toStringList = new List();
 
   factory _ImmutableArray._uninstantiable() {
     throw new UnsupportedError(
         "ImmutableArray can only be allocated by the VM");
   }
 
   E operator [](int index) native "ObjectArray_getIndexed";
 
   void operator []=(int index, E value) {
     throw new UnsupportedError(
@@ skipping 157 matching lines @@
 
   bool get isNotEmpty => !isEmpty;
 
   Iterable<E> get reversed => IterableMixinWorkaround.reversedList(this);
 
   void sort([int compare(E a, E b)]) {
     throw new UnsupportedError(
         "Cannot modify an immutable array");
   }
 
   String toString() {

[floitsch, 2013/07/08 12:00:50]

As above. Change to IterableMixinWorkaround.toStringList(this);

[zarah, 2013/07/08 14:35:15]

Done.

-    return ToString.iterableToString(this);
+    for(int i = 0; i < _toStringList.length; i++) {
+      if(identical(_toStringList[i], this))
+          return '[...]';
+    }
+    _toStringList.add(this);
+    String result = IterableMixinWorkaround.toStringList(this);
+    _toStringList.remove(this);
+    return result;
   }
 
   int indexOf(Object element, [int start = 0]) {
     return Arrays.indexOf(this, element, start, this.length);
   }
 
   int lastIndexOf(Object element, [int start = null]) {
     if (start == null) start = length - 1;
     return Arrays.lastIndexOf(this, element, start);
   }
@@ skipping 78 matching lines @@
     }
     _position = _length;
     _current = null;
     return false;
   }
 
   E get current {
     return _current;
   }
 }