Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasPathMethods.cpp

Issue 1883693002: Zero-length path with round/square lineCap should paint circle on Canvas (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebaseline outdated philip tests to match IE9 and Firefox Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/canvas-zero-length-lineCap-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/canvas2d/CanvasPathMethods.cpp
diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasPathMethods.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasPathMethods.cpp
index 5d3401173b4ba33adbad7deb86fe81173d059645..06432a99b6254c10edb7d310ca754309deb3a626 100644
--- a/third_party/WebKit/Source/modules/canvas2d/CanvasPathMethods.cpp
+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasPathMethods.cpp
@@ -71,8 +71,8 @@ void CanvasPathMethods::lineTo(float x, float y)
FloatPoint p1 = FloatPoint(x, y);
if (!m_path.hasCurrentPoint())
m_path.moveTo(p1);
- else if (p1 != m_path.currentPoint())
- m_path.addLineTo(p1);
+
+ m_path.addLineTo(p1);
}
void CanvasPathMethods::quadraticCurveTo(float cpx, float cpy, float x, float y)
@@ -86,8 +86,8 @@ void CanvasPathMethods::quadraticCurveTo(float cpx, float cpy, float x, float y)
FloatPoint p1 = FloatPoint(x, y);
FloatPoint cp = FloatPoint(cpx, cpy);
- if (p1 != m_path.currentPoint() || p1 != cp)
- m_path.addQuadCurveTo(cp, p1);
+
+ m_path.addQuadCurveTo(cp, p1);
}
void CanvasPathMethods::bezierCurveTo(float cp1x, float cp1y, float cp2x, float cp2y, float x, float y)
@@ -102,8 +102,8 @@ void CanvasPathMethods::bezierCurveTo(float cp1x, float cp1y, float cp2x, float
FloatPoint p1 = FloatPoint(x, y);
FloatPoint cp1 = FloatPoint(cp1x, cp1y);
FloatPoint cp2 = FloatPoint(cp2x, cp2y);
- if (p1 != m_path.currentPoint() || p1 != cp1 || p1 != cp2)
- m_path.addBezierCurveTo(cp1, cp2, p1);
+
+ m_path.addBezierCurveTo(cp1, cp2, p1);
}
void CanvasPathMethods::arcTo(float x1, float y1, float x2, float y2, float r, ExceptionState& exceptionState)
@@ -315,11 +315,6 @@ void CanvasPathMethods::rect(float x, float y, float width, float height)
if (!std::isfinite(x) || !std::isfinite(y) || !std::isfinite(width) || !std::isfinite(height))
return;
- if (!width && !height) {
- m_path.moveTo(FloatPoint(x, y));
- return;
- }
-
m_path.addRect(FloatRect(x, y, width, height));
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/canvas-zero-length-lineCap-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698