Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Side by Side Diff: third_party/WebKit/Source/modules/canvas2d/CanvasPathMethods.cpp

Issue 1883693002: Zero-length path with round/square lineCap should paint circle on Canvas (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: NeedsManualRebaseline Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies)
4 * Copyright (C) 2007 Alp Toker <alp@atoker.com> 4 * Copyright (C) 2007 Alp Toker <alp@atoker.com>
5 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 5 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
6 * Copyright (C) 2008 Dirk Schulze <krit@webkit.org> 6 * Copyright (C) 2008 Dirk Schulze <krit@webkit.org>
7 * Copyright (C) 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserved. 7 * Copyright (C) 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserved.
8 * Copyright (C) 2012, 2013 Intel Corporation. All rights reserved. 8 * Copyright (C) 2012, 2013 Intel Corporation. All rights reserved.
9 * Copyright (C) 2012, 2013 Adobe Systems Incorporated. All rights reserved. 9 * Copyright (C) 2012, 2013 Adobe Systems Incorporated. All rights reserved.
10 * 10 *
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 void CanvasPathMethods::lineTo(float x, float y) 64 void CanvasPathMethods::lineTo(float x, float y)
65 { 65 {
66 if (!std::isfinite(x) || !std::isfinite(y)) 66 if (!std::isfinite(x) || !std::isfinite(y))
67 return; 67 return;
68 if (!isTransformInvertible()) 68 if (!isTransformInvertible())
69 return; 69 return;
70 70
71 FloatPoint p1 = FloatPoint(x, y); 71 FloatPoint p1 = FloatPoint(x, y);
72 if (!m_path.hasCurrentPoint()) 72 if (!m_path.hasCurrentPoint())
73 m_path.moveTo(p1); 73 m_path.moveTo(p1);
74 else if (p1 != m_path.currentPoint()) 74
75 m_path.addLineTo(p1); 75 m_path.addLineTo(p1);
76 } 76 }
77 77
78 void CanvasPathMethods::quadraticCurveTo(float cpx, float cpy, float x, float y) 78 void CanvasPathMethods::quadraticCurveTo(float cpx, float cpy, float x, float y)
79 { 79 {
80 if (!std::isfinite(cpx) || !std::isfinite(cpy) || !std::isfinite(x) || !std: :isfinite(y)) 80 if (!std::isfinite(cpx) || !std::isfinite(cpy) || !std::isfinite(x) || !std: :isfinite(y))
81 return; 81 return;
82 if (!isTransformInvertible()) 82 if (!isTransformInvertible())
83 return; 83 return;
84 if (!m_path.hasCurrentPoint()) 84 if (!m_path.hasCurrentPoint())
85 m_path.moveTo(FloatPoint(cpx, cpy)); 85 m_path.moveTo(FloatPoint(cpx, cpy));
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 return; 316 return;
317 317
318 if (!width && !height) { 318 if (!width && !height) {
319 m_path.moveTo(FloatPoint(x, y)); 319 m_path.moveTo(FloatPoint(x, y));
320 return; 320 return;
321 } 321 }
322 322
323 m_path.addRect(FloatRect(x, y, width, height)); 323 m_path.addRect(FloatRect(x, y, width, height));
324 } 324 }
325 } // namespace blink 325 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698